Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLA-696][external] Allow registration of single-slotted read-write files from external storage #785

Merged
merged 16 commits into from Mar 12, 2024
Merged

[PLA-696][external] Allow registration of single-slotted read-write files from external storage #785

merged 16 commits into from Mar 12, 2024

Conversation

JBWilkie
Copy link
Contributor

@JBWilkie JBWilkie commented Mar 9, 2024

Problem

Currently, the REST API is the only way to register externally stored items. The ability to register items using darwin-py is simpler in some scenarios and can prevent difficult-to-spot payload errors

Solution

Added user-facing objects & methods to register single-slotted read-write items from external storage

Changelog

Added ability to register single-slotted read-write files from external storage in darwin-py

@linear Linear
Copy link

linear bot commented Mar 9, 2024

PLA-696 Allow clients to connect to configured external storage through an ObjectStore object

@JBWilkie JBWilkie requested a review from saurbhc March 11, 2024 12:07
saurbhc
saurbhc approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@saurbhc saurbhc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏

darwin/client.py Show resolved Hide resolved
darwin/client.py Outdated Show resolved Hide resolved
darwin/client.py Outdated Show resolved Hide resolved
darwin/dataset/local_dataset.py Show resolved Hide resolved
darwin/dataset/remote_dataset_v2.py Show resolved Hide resolved
darwin/dataset/utils.py Outdated Show resolved Hide resolved
darwin/dataset/utils.py Show resolved Hide resolved
darwin/dataset/remote_dataset_v2.py Outdated Show resolved Hide resolved
darwin/objectstore.py Outdated Show resolved Hide resolved
tests/darwin/cli_functions_test.py Show resolved Hide resolved
JBWilkie and others added 9 commits March 12, 2024 12:39
@JBWilkie @saurbhc
Update darwin/client.py
833afdd 
Co-authored-by: saurbhc <sc@saurabhchopra.co.uk>
@JBWilkie @saurbhc
Update darwin/client.py
6be0b83 
Co-authored-by: saurbhc <sc@saurabhchopra.co.uk>
@JBWilkie @saurbhc
Update darwin/client.py
05d686e 
Co-authored-by: saurbhc <sc@saurabhchopra.co.uk>
@JBWilkie @saurbhc
Update darwin/dataset/utils.py
8cacfad 
Co-authored-by: saurbhc <sc@saurabhchopra.co.uk>
@JBWilkie @saurbhc
Update darwin/dataset/remote_dataset_v2.py
9482d88 
Co-authored-by: saurbhc <sc@saurabhchopra.co.uk>
@JBWilkie
Small changes, mostly docstrings
4c260aa
@JBWilkie
Merge branch 'PLA-696' of https://github.com/v7labs/darwin-py into PL…
6fe85a1 
…A-696
@JBWilkie
Linting
d45be9b
@JBWilkie @saurbhc
Update darwin/dataset/utils.py
004c5ff 
Co-authored-by: saurbhc <sc@saurabhchopra.co.uk>
@JBWilkie JBWilkie merged commit 37157db into master Mar 12, 2024
16 checks passed
@saurbhc saurbhc deleted the PLA-696 branch March 12, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saurbhc saurbhc saurbhc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JBWilkie @saurbhc