Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLA-683][external] 2 Minor fixes for importing of PASCAL VOC annotations #783

Merged
merged 4 commits into from Mar 7, 2024

Conversation

JBWilkie
Copy link
Contributor

@JBWilkie JBWilkie commented Mar 6, 2024

Problem

2 issues:

  • 1: get_remote_files() was calling fetch_remote_files() with an incorrect filter parameter filenames instead of item_names
  • 2: PASCAL VOC annotations could not be imported to dataset items outside of the root folder

Solution

  • Fix for problem 1: Updated get_remote_files() so that it passes item_names instead of filenames to fetch_remote_files()
  • Fix for problem 2: Added logic to split the filename into remote_path and an updated filename if a remote path is included in the filename

Changelog

  • Fixed a misnamed querystring filter parameter in fetch_remote_files()
  • Added support for importing PASCAL VOC annotations to dataset items outside of the root folder '/'

Copy link

linear bot commented Mar 6, 2024

@saurbhc saurbhc self-requested a review March 7, 2024 11:51
Copy link
Member

@saurbhc saurbhc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏

@JBWilkie JBWilkie merged commit b9d1430 into master Mar 7, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants