[AI-1486] fix darwin py 0835 bug loading version in videos #752
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There are a few updates in latest
darwin-py
that breaks other parts of the code.First, the get_darwin_json_version method assumes a flat structure of json files. Which is not true when we download with folders and/or video.
with open(next(annotations_dir.glob("*.json")), "r") as file:
Secondly, the
compute_distributions
will now add an extra.json
on top of what is now the fill file path (with suffix).darwin-py/darwin/dataset/utils.py
Line 727 in a8d24aa
Example usage:
Thirdly, the get_image_path_from_stream` has now additional required arguments. This function is being used since before in _map_annotations_to_images and that one has not been updated to take the new arguments into account.
Solution
Changelog
(Will appear in release docs)