-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support to put a torch module into all vineyard instances dispersedly #1891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashanji
force-pushed
the
shuffle-torch-modules
branch
from
May 16, 2024 02:50
cc68a5c
to
13e3f49
Compare
dashanji
force-pushed
the
shuffle-torch-modules
branch
3 times, most recently
from
May 20, 2024 09:37
ca55aed
to
1aaab98
Compare
Hi @sighingnow, could you please take a look at this? |
dashanji
force-pushed
the
shuffle-torch-modules
branch
3 times, most recently
from
May 24, 2024 02:24
b5ff7bb
to
6532ea2
Compare
dashanji
changed the title
Support to shuffle torch module in rpc client
Support to put a torch module into all vineyard instances dispersedly
May 24, 2024
dashanji
force-pushed
the
shuffle-torch-modules
branch
from
May 24, 2024 06:15
1e21c20
to
ffa38a3
Compare
sighingnow
approved these changes
Jun 3, 2024
python/vineyard/core/client.py
Outdated
@@ -729,5 +741,13 @@ def with_compression(self, enabled: bool = True): | |||
yield | |||
self.compression = compression | |||
|
|||
@contextlib.contextmanager | |||
def with_dispersion(self, enabled: bool = True): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dispersion -> spread
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
dashanji
force-pushed
the
shuffle-torch-modules
branch
from
June 3, 2024 07:10
ffa38a3
to
78dd521
Compare
Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
sighingnow
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Related issue number
Fixes #1884