Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt k8s to v1.19.3. #1760

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Adapt k8s to v1.19.3. #1760

wants to merge 3 commits into from

Conversation

dashanji
Copy link
Member

@dashanji dashanji commented Feb 19, 2024

What do these changes do?

  • Adapt k8s to v1.19.3.
  • Replace the log package in go/vineyard with k8s/pkg/log.
  • Use the log implementation under k8s/pkg to replace the log implementation under go/vineyard.

Related issue number

Fixes #1651

@sighingnow
Copy link
Member

Replace the log package in go/vineyard with k8s/pkg/log.

Don't do that. The package go/vineyard is expected to be used as a standalone package and requiring k8s components/packages in such a data structure package looks quite wired.

@dashanji
Copy link
Member Author

Ok, I will try to fix the version compatibility between go/vineyard/log and k8s/pkg/log.

@dashanji dashanji force-pushed the adapt-k8s-1.19 branch 3 times, most recently from a8126d1 to ccc4c99 Compare February 19, 2024 11:02
@dashanji
Copy link
Member Author

dashanji commented Feb 19, 2024

Sorry for the previous confusing description and please check the updated one. Actually, the k8s@v1.19 depends on a low version of github.com/go-logr/logr but the current log implementation in go/vineyard requires a high version. Thus, I implemented the log package in the go/vineyard and reused the logic in the k8s/pkg/log.

@dashanji dashanji changed the title Adapt k8s to v1.19.3. [WIP] Adapt k8s to v1.19.3. Feb 20, 2024
@dashanji
Copy link
Member Author

The vineyard scheduler is closely related to the k8s version. As the scheduler configurations of lower versions will be deprecated in higher versions of k8s, we can't support multiple versions (v1beta1, v1beta2, v1beta3, and v1) of scheduler configuration in the same codebase.

A possible way is to find the lowest version of scheduler configuration and make sure it can work in the latest k8s cluster.

@github-actions github-actions bot added the stale label Mar 12, 2024
Copy link
Contributor

/cc @sighingnow, this issus/pr has had no activity for a long time, please help to review the status and assign people to work on it.

sighingnow and others added 2 commits April 28, 2024 21:03
Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
@dashanji dashanji changed the title [WIP] Adapt k8s to v1.19.3. Adapt k8s to v1.19.3. Apr 28, 2024
@dashanji dashanji requested a review from sighingnow May 6, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Vineyard Operator compatible with a certain range of lower versions of k8s
2 participants