Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Vineyard Operator compatible with a certain range of lower versions of k8s #1651

Open
dashanji opened this issue Dec 15, 2023 · 3 comments · May be fixed by #1760
Open

Make Vineyard Operator compatible with a certain range of lower versions of k8s #1651

dashanji opened this issue Dec 15, 2023 · 3 comments · May be fixed by #1760
Assignees
@dashanji
Labels
enhancement New feature or request kubernetes stale

Comments

@dashanji
Copy link
Member

dashanji commented Dec 15, 2023 •
edited

Describe your problem

What is the problem:

Recently, when users were running some examples with a lower version of k8s (e,g. 1.23). Some components of vineyard operator can't work as expected.

The behaviour that you expect to work:

It's better to make vineyard operator compatible with a certain range of lower versions of k8s (1.19~). A possible way is to
writer a wrapper, which can build the different images of vineyard operator for different k8s version and push the image as vineyardcloudnative/vineyard-operator:(vineyard-version)-(k8s-version) such as vineyardcloutnative/vineyard-operator:0.19.1-k8s1.19. Besides, we need to add a flag k8s.version to the helm chart.
@dashanji dashanji added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 15, 2023
@dashanji dashanji changed the title Claim the minimum version of the components required to run the example in all vineyard docs Compatible with a certain range of lower versions of k8s Dec 15, 2023
@dashanji dashanji changed the title Compatible with a certain range of lower versions of k8s Make Vineyard Operator compatible with a certain range of lower versions of k8s Dec 15, 2023
@sighingnow sighingnow added kubernetes and removed documentation Improvements or additions to documentation labels Dec 18, 2023
@dashanji dashanji mentioned this issue Dec 18, 2023
Merged
@sighingnow
Copy link
Member

. A possible way is to
writer a wrapper, which can build the different images of vineyard operator for different k8s version and push the image as

Don't do that. The compatibility should be implemented in the source level and the compatiblity (which version range of K8s would work) should be clearly documented.

@sighingnow
Copy link
Member

Any progress or update on the this issue?

@dashanji
Copy link
Member Author

WIP, see also https://github.com/dashanji/v6d/tree/adapt-k8s-1.18

@dashanji dashanji linked a pull request Feb 19, 2024 that will close this issue
Open
@github-actions github-actions bot added the stale label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dashanji dashanji

Labels
enhancement New feature or request kubernetes stale
Projects
Vineyard Releases
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adapt k8s to v1.19.3. dashanji/v6d
2 participants
@sighingnow @dashanji