Docker run restart policy support #40
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
omesser
commented
Jan 6, 2021
•
omesser
commented
- Restart policy flags can now be defined as an Image property
- Minor changes/fixes in tests
- Added pycharm runConfigurations
- Added some non default properties to test shell commands
omesser
force-pushed
the
restart_support
branch
from
1f3bd81
to
41e506a
Compare
omesser
force-pushed
the
restart_support
branch
from
41e506a
to
3589c2a
Compare
liranbg
reviewed
Feb 29, 2024
| @@ -53,7 +53,7 @@ def main(): | |||
| # (from a local dir if it exists) | |||
| # "python -m pip install" instead of "pip install" handles a pip | |||
| # issue where it fails in a long-named dir | |||
| run('virtualenv --python=python3 venv && ' | |||
| run('virtualenv --python=python3.7 venv && ' | |||
There was a problem hiding this comment.
since we also support manof atop python 3.9, this needs to stay python3 and below, on project.toml, leave it to be either 3.7 or 3.9
There was a problem hiding this comment.
@liranbg - thanks for the review!
Getting back to this now. I understand manof needs compatibility with both 3.7 and 3.9, but since this is an install script, several questions:
- developers - I suppose they should all align to 3.9, right? there should be a single developer version for the repo. even if it's overridable, or BC with other python version. traditionally this is the highest supported version. Should we change CI scripts to install and test 3.9?
- Is there a scenario where install script is used sometimes in 3.7.X env and sometimes in 3.9.x env? I think it's only used in the makefile for dev environment. but maybe in the internal iguazio deployment script it is called from somewhere as well so that's why it should support both?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.