Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: migrate from github.com/golang/protobuf to google.golang.org/protobuf #2844

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

yin1999
Copy link
Contributor

@yin1999 yin1999 commented Jan 7, 2024

Fixes: #2650

@yin1999 yin1999 changed the title buid: migrate from github.com/golang/protobuf to google.golang.org/protobuf build: migrate from github.com/golang/protobuf to google.golang.org/protobuf Jan 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2024

Codecov Report

Attention: Patch coverage is 34.11765% with 56 lines in your changes are missing coverage. Please review.

Project coverage is 35.61%. Comparing base (49b5068) to head (6f8dfce).

Files Patch % Lines
infra/conf/jsonpb/jsonpb.go 0.00% 9 Missing ⚠️
common/serial/resolver.go 0.00% 8 Missing ⚠️
common/registry/registry.go 12.50% 7 Missing ⚠️
infra/conf/v4/api.go 0.00% 6 Missing ⚠️
infra/conf/v4/services.go 0.00% 6 Missing ⚠️
infra/conf/v2jsonpb/follower.go 0.00% 4 Missing ⚠️
common/serial/typed_message.go 80.00% 1 Missing and 2 partials ⚠️
transport/internet/grpc/dial.go 0.00% 3 Missing ⚠️
infra/conf/v2jsonpb/v2jsonpb.go 0.00% 2 Missing ⚠️
transport/internet/config.go 71.42% 2 Missing ⚠️
... and 6 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2844   +/-   ##
=======================================
  Coverage   35.60%   35.61%           
=======================================
  Files         729      728    -1     
  Lines       41612    41609    -3     
=======================================
+ Hits        14818    14821    +3     
+ Misses      25161    25156    -5     
+ Partials     1633     1632    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yin1999 yin1999 marked this pull request as ready for review March 4, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

do you want to update github.com/golang/protobuf to google.golang.org/protobuf ?
2 participants