Pull Request honestbleeps#5478: Fix: download images from posts with …

…emoji-only, extra long, exotic emoji containing titles
uwx · Nov 8, 2023 · a211a50 · a211a50
2 parents 6a952ad + 9cf96e3
commit a211a50
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/lib/modules/showImages.js b/lib/modules/showImages.js
@@ -1333,11 +1333,13 @@ export class Media {
 						const ext = re.exec(downloadUrl);
 						const thing = Thing.from(wrapper);
 						let title = thing && thing.getTitle();
+						title = title.replace(/[*|?:"~<>\\\/]|(\u00a9|\u00ae|[\u2000-\u3300]|\ud83c[\ud000-\udfff]|\ud83d[\ud000-\udfff]|\ud83e[\ud000-\udfff])/gi, '');
+						title = title.replace(/\p{Emoji}|\p{Emoji_Component}/ug, '');
+						title = title.slice(0, 120); // titles may be longer than the filesystem allows
+						title = title.trim();
 						if (title && ext) {
 							let extension = ext[1];
 							if (extension.includes('?')) extension = extension.split('?')[0];
-							title = title.replace(/[*|?:"~<>\\\/]|(\u00a9|\u00ae|[\u2000-\u3300]|\ud83c[\ud000-\udfff]|\ud83d[\ud000-\udfff]|\ud83e[\ud000-\udfff])/gi, '');
-							title = title.trim();
 							const filename = `${title}.${extension}`;
 							download(downloadUrl, filename);
 						} else download(downloadUrl);