Add Excel route model conversion function #37
Conversation
There was a problem hiding this comment.
@landont168 PR looks solid. I have mentioned couple of changes and also there are some linting errors. You can fix them by checking it with the python black formatter
Most of them can be fixed by running black etk_route.py (installation here: https://github.com/psf/black?tab=readme-ov-file#installation-and-usage)
| @@ -0,0 +1,41 @@ | |||
| # Note: Need to 'pip install openpyxl' | |||
There was a problem hiding this comment.
You can add this to the requirements.txt.
To do that, just do pip freeze and get all of the requirements and paste them or pipe them to requirements.txt
Command: pip freeze > requirements.txt
|
|
||
| def main(): | ||
| # Set Excel file name | ||
| excel_file_name = "route-steps-2022.xlsx" |
There was a problem hiding this comment.
As @rodrigotiscareno mentioned take this as a command line input. To make it a bit better try and use the questionary library used by Ryan in the other files and take it using that.
Also add the command line argument to take the output file (different from the input file)
No description provided.