[SOFT 999] FW 103 HW #504
Open
[SOFT 999] FW 103 HW #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
projects/fw_103_hw/src/main.c
Outdated
| .priority = INTERRUPT_PRIORITY_HIGH, | ||
| }; | ||
|
|
||
| adc_set_channel_pin(button_addr, true); |
There was a problem hiding this comment.
The adc should be set for the potentiometer pin, instead of the button
|
|
||
|
|
||
| // GPIO address that we will allow us to read button data | ||
| const GpioAddress potentiometer_addr_A6 = { // could be passed as context |
There was a problem hiding this comment.
Good programming practice is to not to use global variables (ie any variable that is non-static declared outside a function). The const is good since they won't be changed, but declare them static as well const static
| adc_init(ADC_MODE_SINGLE); | ||
|
|
||
| // GPIO Address where button is pressed | ||
| GpioAddress potentiometer_addr_B2 = { |
There was a problem hiding this comment.
This wouldn't be a potentiometer address, this would be a button address, so it would be good to label it as such
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FW 103 HW