[SOFT-501] Uncommitted Protobuf Generated Code Check in CI #412
Conversation
Auto generated code from proto files removed from .gitignore
Extended uncommitted codegen checking in CI to also check uncommitted protobuf files. Added make mu_protos command to build protos for MU New incomplete .md file for constant comment to post into github.
Just trying to get jobs to build.
…w-midsun/firmware_xiv into soft_501_commit_generated_code
…w-midsun/firmware_xiv into soft_501_commit_generated_code
Cache check
…w-midsun/firmware_xiv into soft_501_commit_generated_code
…s to 60, add additional restore key for caching
| /usr/local/include/google/protobuf | ||
| /usr/local/include/google/protobuf-c | ||
| /usr/local/include/protobuf-c | ||
| /usr/local/lib |
There was a problem hiding this comment.
Try and rerun the CI jobs to see if the caching works; if it does, great, but if it doesn't, I worry that caching all of /usr/local/lib will cause issues. I assume there's a particular protobuf library in there that you want to cache, so to cache only that library I'd recommend copying it from /usr/local/lib to some path you can restore (like make ~/.cache/protobuf or something and copy it there) in the install-protobuf step, then copying it back in a step that runs if the cache successfully restored.
|
Note to self: If check cancels, try again in a couple hours. |
|
Note: in order to get the checks to run again you'll need to merge master (and deal with merge conflicts) because the github actions ubuntu-16.04 environment was removed and we've updated it to 18.04 on master. |
See commit comments for details.
Not exactly sure what to write in .md file