Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Soft 389 can rx polling #289

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Soft 389 can rx polling #289

wants to merge 7 commits into from

Conversation

Max-MZ
Copy link
Contributor

@Max-MZ Max-MZ commented Feb 20, 2021

increased timeout on CAN
small change on naming in wait.c

ryandancy
ryandancy approved these changes Feb 20, 2021
View reviewed changes
Copy link
Collaborator

@ryandancy ryandancy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it's just a matter of if we can get CI to pass lol. I don't think it should affect our test flakiness issues but it's possible.

@ryandancy
Copy link
Collaborator

Looks like the change is consistently causing test_rear_pd_fan_ctrl_temp in power_distribution/test/test_fan_ctrl.c to fail, could you look into it?

@ryandancy
Copy link
Collaborator

Update: looks like @jessm's efforts in bypassing vcan in loopback mode fixed the failing test, I'll merge once CI passes.

ryandancy and others added 2 commits April 4, 2021 10:51
@ryandancy
Rewrite test_can_wake_works to avoid infinite looping
6d87cd9 
There was a very odd race condition in test_can_wake_works where very
occasionally it would loop forever. Not sure why, but it also wasn't
testing what it was supposed to particularly effectively, so I rewrote
it.

Also added a couple of x86_interrupt_wake() calls in can_hw to be safe.
@ryandancy
Merge branch 'master' into soft_389_can_rx_polling
14054d4
@ryandancy ryandancy requested a review from jessm April 4, 2021 14:52
@ryandancy ryandancy marked this pull request as draft April 4, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryandancy ryandancy ryandancy approved these changes

@jessm jessm Awaiting requested review from jessm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Max-MZ @ryandancy