Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS - Tooltip: positioning fix #3963 #4062

Merged
merged 33 commits into from
Mar 12, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
5c2da2a
min width to force psuedo element from getting too small for the content
gscottqueen Jan 27, 2021
980771e
including some additional fall back logic for content clipping
gscottqueen Jan 27, 2021
5c1bc10
one function to find best position based on visiblity
gscottqueen Jan 28, 2021
b256b8c
updated styles to handle larger and smaller content sizes
gscottqueen Jan 28, 2021
d521b8e
adding a fallback for no visible positions, and comments
gscottqueen Jan 28, 2021
6862c86
corrected spelling
gscottqueen Jan 28, 2021
6803464
clean up syntax
gscottqueen Jan 28, 2021
d2572c6
debugging
gscottqueen Feb 4, 2021
cfc9ed3
we clear positioning from dynamic tries
gscottqueen Feb 8, 2021
e1ce5e7
removes some unused code
gscottqueen Feb 8, 2021
0c99169
including logic to handle utilities with larger offsets
gscottqueen Feb 8, 2021
0fe4069
removes commentd code
gscottqueen Feb 8, 2021
a7281ea
prettier file and set up margin for utility offsets
gscottqueen Feb 10, 2021
78d6fe5
trying out a new strategy for right alignment
gscottqueen Feb 10, 2021
e2f27a8
Merge branch 'gsq-tooltip-fix' of git://github.com/gscottqueen/uswds …
mejiaj Feb 11, 2021
49e4a81
setting back
gscottqueen Feb 11, 2021
6f26a71
updated our right position calc fc
gscottqueen Feb 12, 2021
016915e
converting to arrow functions, action follows
gscottqueen Feb 12, 2021
1a6eba1
adding comments, format file
gscottqueen Feb 12, 2021
6a83aae
Merge branch 'develop' of https://github.com/uswds/uswds into gsq-too…
gscottqueen Feb 12, 2021
d83b327
getting rid of unneeded Promise
gscottqueen Feb 12, 2021
7e8df27
fommat code
gscottqueen Feb 12, 2021
1106ea2
Merge branch 'gsq-tooltip-fix' of git://github.com/gscottqueen/uswds …
mejiaj Feb 16, 2021
24245d4
renames recursive fucntion
gscottqueen Feb 16, 2021
bcbde03
Merge branch 'develop' of https://github.com/uswds/uswds into gsq-too…
gscottqueen Feb 16, 2021
379a5d4
Merge branch 'develop' of https://github.com/uswds/uswds into gsq-too…
gscottqueen Feb 19, 2021
0931ecc
Merge branch 'develop' of https://github.com/uswds/uswds into gsq-too…
gscottqueen Feb 22, 2021
e3b3bb9
clean up lint test errors
gscottqueen Feb 24, 2021
ebf77e9
Merge branch 'develop' of github.com:uswds/uswds into gscottqueen-gsq…
scottqueen-bixal Mar 2, 2021
303f379
Merge branch 'develop' of https://github.com/uswds/uswds into gsq-too…
gscottqueen Mar 2, 2021
a5e5342
Merge branch 'gsq-tooltip-fix' of github.com:gscottqueen/uswds into g…
scottqueen-bixal Mar 2, 2021
ae7fb1e
includes a manual test for reactive positioning of tooltips
scottqueen-bixal Mar 2, 2021
5f4d55e
Merge branch 'develop' of github.com:uswds/uswds into gscottqueen-gsq…
scottqueen-bixal Mar 4, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
112 changes: 112 additions & 0 deletions src/components/test/tooltip-utilites.njk
Original file line number Diff line number Diff line change
@@ -0,0 +1,112 @@
<h2>In a footer</h2>
<hr/>
<p>In this scenario:
<ul>
<li>at screensizes greater than 1548, tooltip that is positioned top with a long description should appear as expected</li>
<li>at screensizes less than 1550px and greater than 320, tooltip that is positioned top with a long description should not be visible in the window without being cut off</li>
<li>at screensizes of apx 320, tooltip that is positioned top with a long description should be compressed and visible in the window without being cut off</li>
</ul>
</p>
<footer class="usa-footer">
<div class="grid-container usa-footer__return-to-top">
<a href="#">Return to top</a>
</div>
<div class="usa-footer__primary-section">
<nav class="usa-footer__nav" aria-label="Footer navigation">
<ul class="grid-row grid-gap">
<li class="mobile-lg:grid-col-4 desktop:grid-col-auto usa-footer__primary-content">
<a class="usa-footer__primary-link" href="javascript:void(0);">Primary link</a>
</li>
<li class="mobile-lg:grid-col-4 desktop:grid-col-auto usa-footer__primary-content">
<a class="usa-footer__primary-link" href="javascript:void(0);">Primary link</a>
</li>
<li class="mobile-lg:grid-col-4 desktop:grid-col-auto usa-footer__primary-content">
<a class="usa-footer__primary-link" href="javascript:void(0);">Primary link</a>
</li>
<li class="mobile-lg:grid-col-4 desktop:grid-col-auto usa-footer__primary-content">
<a class="usa-footer__primary-link" href="javascript:void(0);">Primary link</a>
</li>
<li class="mobile-lg:grid-col-4 desktop:grid-col-auto usa-footer__primary-content">
<a class="usa-footer__primary-link" href="javascript:void(0);">Primary link</a>
</li>
</ul>
</nav>
</div>

<div class="usa-footer__secondary-section">
<div class="grid-container">
<div class="grid-row grid-gap">
<div class="usa-footer__logo grid-row mobile-lg:grid-col-6 mobile-lg:grid-gap-2">
<div class="mobile-lg:grid-col-auto">
<img class="usa-footer__logo-img" src="{{ uswds.path }}/img/logo-img.png" alt="">
</div>
<div class="mobile-lg:grid-col-auto">
<p class="usa-footer__logo-heading">Name of Agency</p>
</div>
</div>
<div class="usa-footer__contact-links mobile-lg:grid-col-6">
<div class="usa-footer__social-links grid-row grid-gap-1">
<div class="grid-col-auto">
<a class="usa-social-link usa-social-link--facebook usa-tooltip" data-position="top" title="Top" href="javascript:void(0);">
<span>Facebook</span>
</a>
</div>
<div class="grid-col-auto">
<a class="usa-social-link usa-social-link--twitter usa-tooltip" data-position="top" title="Top" href="javascript:void(0);">
<span>Twitter</span>
</a>
</div>
<div class="grid-col-auto">
<a class="usa-social-link usa-social-link--youtube usa-tooltip" data-position="top" title="Top" href="javascript:void(0);">
<span>YouTube</span>
</a>
</div>
<div class="grid-col-auto">
<a class="usa-social-link usa-social-link--instagram usa-tooltip" data-position="top" title="Top" href="javascript:void(0);">
<span>Instagram</span>
</a>
</div>
<div class="grid-col-auto">
<a class="usa-social-link usa-social-link--rss usa-tooltip" data-position="top" title="A longer Top tooltip that is longer than appx 320px" href="javascript:void(0);">
<span>RSS</span>
</a>
</div>
</div>
<h3 class="usa-footer__contact-heading">Agency Contact Center</h3>
<address class="usa-footer__address">
<div class="usa-footer__contact-info grid-row grid-gap">
<div class="grid-col-auto">
<a href="tel:1-800-555-5555">(800) CALL-GOVT</a>
</div>
<div class="grid-col-auto">
<a href="mailto:info@agency.gov">info@agency.gov</a>
</div>
</div>
</address>
</div>
</div>
</div>
</div>
</footer>
<h2>In a utility</h2>
<hr/>
<p>In this scenario:
<ul>
<li>Because the "right" positioned tooltip description is appx 320px+, it should never be visible on the right side</li>
<li>at screensizes of apx 320, tooltip that is positioned "right" with a long description should be compressed and visible in the window without being cut off</li>
</ul>
</p>
<div class="grid-row padding-8">
<div class="tablet:grid-col-3 margin-top-2 text-center">
<button type="button" class="usa-button usa-tooltip" data-position="top" data-classes="{{tooltip.classes}}" title="Top">Show on top</button>
</div>
<div class="tablet:grid-col-3 margin-top-2 text-center">
<button type="button" class="usa-button usa-tooltip" data-position="bottom" data-classes="{{tooltip.classes}}" title="Bottom">Show on bottom</button>
</div>
<div class="tablet:grid-col-3 margin-top-2 text-center">
<button type="button" class="usa-button usa-tooltip" data-position="left" data-classes="{{tooltip.classes}}" title="Left">Show on left</button>
</div>
<div class="tablet:grid-col-3 margin-top-2 text-center">
<button type="button" class="usa-button usa-tooltip" data-position="right" title="A longer Top tooltip that is longer than appx 320px" data-classes="{{tooltip.classes}}" title="">Show on Right</button>
</div>
</div>