Memorize the C string representation. #495
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some cases, the computation of the C string for inline using _getRepresentation takes a substantial amount of time. Here, we memorize the computed C code and argument dictionary. The argDict used to store the values of the required variables. Now it stores the variables themselves, and the values are retrieved by _execInline.
|
@cjgillot, thanks for this, we currently don't have the time to look into this pull request, but in the next round of FiPy development we will likely merge try and merge it. |
|
This might be too difficult for me to get into right now. I think I'll take myself off this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some cases, the computation of the C
string for inline using _getRepresentation
takes a substantial amount of time.
Here, we memorize the computed C code and argument dictionary.
The argDict used to store the values of the required variables.
Now it stores the variables themselves,
and the values are retrieved by _execInline.
I have been using this patch offline for a while,
and it does not seem to harm anything.
What is your opinion about this ?