fix: generalizes player search query format #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the search query was used monolithically as a single string to match the members' member id or their (comma-separated) full name; this had many shortcomings, e.g., a search query " 12345 " would fail to match a member with id "12345", and a search query "surname name" would fail to match a member with full name "surname, name". Also see usgo#164 and usgo#248. In this commit, the search is first stripped of outer whitespace, which helps search for member ids. If the search query is not an id, then the search query is split into tokens, and a match with a member is found if all of the respective query tokens match the member's full name. This allows users to run queries such as "name", "surname", "name surname" or "surname name".
|
Seems like the |
|
@abaisero Just letting you know that I have seen this request, and I will be working on taking some time aside to look at it. If you are interested in getting more involved in our projects and chatting more, you can email us at either webmaster@usgo.org. If you do drop an email, please tell us a little about yourself and what got you interested in our projects. |
amj
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the search query was used monolithically as a
single string to match the members' member id or their (comma-separated)
full name; this had many shortcomings, e.g., a search query " 12345 "
would fail to match a member with id "12345", and a search query
"surname name" would fail to match a member with full name "surname,
name". Also see #164 and #248.
In this commit, the search is first stripped of outer whitespace, which
helps search for member ids. If the search query is not an id, then the
search query is split into tokens, and a match with a member is found if
all of the respective query tokens match the member's full name. This
allows users to run queries such as "name", "surname", "name surname" or
"surname name".