Improve Search Function of the AGAGD #164
Labels
Projects
Milestone
Comments
michaelhiiva
added
bug
|
Related #241. |
abaisero
added a commit
to abaisero/agagd
that referenced
this issue
Apr 5, 2022
Prior to this commit, the search query was used monolithically as a single string to match the members' member id or their (comma-separated) full name; this had many shortcomings, e.g., a search query " 12345 " would fail to match a member with id "12345", and a search query "surname name" would fail to match a member with full name "surname, name". Also see usgo#164 and usgo#248. In this commit, the search is first stripped of outer whitespace, which helps search for member ids. If the search query is not an id, then the search query is split into tokens, and a match with a member is found if all of the respective query tokens match the member's full name. This allows users to run queries such as "name", "surname", "name surname" or "surname name".
|
Search by ID seems broken - https://agagd.usgo.org/search/?q=14460 gives me a 500 in production |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary of the Bug
Currently the AGAGD requires a search to be in a specific format such as:
[lastname], [firstname],[lastname]or [id].The Expected Behaviour
The search should be able to handle other criteria like: "tournaments," "games vs," "by firstname" and other advanced searches.
The text was updated successfully, but these errors were encountered: