Fix: bug when boolean false was extracted from var as nil #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VitaliSakolski
approved these changes
Mar 7, 2024
Stashchenko
reviewed
Mar 7, 2024
tetianaa-oprysk
approved these changes
Mar 7, 2024
Teckden
reviewed
Mar 7, 2024
spec/json_logic/evaluator_spec.rb
Outdated
| let(:data) { { 'a' => true } } | ||
| let(:var_name) { 'a' } | ||
|
|
||
| it { is_expected.to be_truthy } |
There was a problem hiding this comment.
truthy is a bit vague, can you please set the exact expectation for the returned value?
It is recommended to: The be matcher is too generic, as it pass on everything that is not nil or false. If that is the exact intend, use be_truthy. In all other cases it’s better to specify what exactly is the expected value.
https://docs.rubocop.org/rubocop-rspec/cops_rspec.html#rspecbe
Stashchenko
approved these changes
Mar 7, 2024
Teckden
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug when method #
get_var_valueextracts from boolean variablenilinstead offalse