Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variable size on step_pulse_time for STM32 targets #66

Open
wants to merge 2 commits into
base: edge
Choose a base branch
from

Conversation

duembeg
Copy link

@duembeg duembeg commented Apr 7, 2019

  • Fixed issue with size of step_pulse_time, it is a uint8 but for STM32
    and clk source of 72MHz these would be 720 for 10us pulse; uint8 can
    only hold 255 max. Changed type to uint16 on stm32 targets.
    Currently is being truncated 0x2D0 to 0xD0 (208).

Wilhelm Duembeg and others added 2 commits April 7, 2019 15:50
* Fixed issue with size of step_pulse_time, it is a uint8 but for STM32
  and clk source of 72MHz these would be 720 for 10us pulse; uint8 can
  only hold 255 max. Changed type to uint16 on stm32 targets.
Fix bug with size for step_pulse_time for STM32
Copy link

@bygreencn bygreencn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants