Generation of PNGs screenshots: added target and misc #867
Conversation
|
Related to #358 |
to avoid c++ confusion with the compiler
|
This is ready for my side! |
| DISPLAY=:$DISPLAYNUM # this still doesn't work | ||
|
|
||
| # export DISPLAY=:$DISPLAYNUM | ||
| # Uncomment this if you want hide the spawned urxvt windows and only want to | ||
| # see the results in the pngs. | ||
| # It will display many warning messages in xdotool. In particular, the messages are: | ||
| # XGetInputFocus returned the focused window of 1. This is likely a bug in the X server. | ||
| # but it works. | ||
|
|
There was a problem hiding this comment.
Sorry but no, this specific change will break building docs on CI.
We do need to explicitly point urxvt & xdotool to X11-connect to DISPLAY=:5. This is why we're running a "virtual X-server" on address :5 hosted by Xvfb in the first place.
On a desktop linux, with your change applied, the script will inherit DISPLAY=:0 most likely — so urxvt will start connecting to your graphical session, you'll see the terminal — and the Xvfb instance will be completely unused. Xdotool will also be able to grab screenshots. So what's the problem?
The problem is, in CI containers there's no X server and no DISPLAY=:0. There we need Xvfb. And to not create extra discrepancies in testing, it's best to also use Xvfb locally.
You can comment out the DISPLAY=:$DISPLAYNUM line in your local copy — but don't commit that. It will break CI.
| until RXVTWINDOWID=$(xdotool search --classname "$CLASSNAME"); do | ||
| sleep 0.1 | ||
| done | ||
| RXVTWINDOWID=$(xdotool search --sync --classname "$CLASSNAME") |
Alright, I will read them. A first question arises to me. What do you mean by
That change should not have effect since the
It makes sense 👍 |
Checklist
masterorpython-dual-supportbranchtoxsuccessfully in local environmentDescription:
(P. S. If this pull requests fixes an existing issue, please specify which one.)