Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing requests session for customisation #170

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zacps
Copy link

@zacps zacps commented Dec 4, 2023

This lets users customise network behaviour, for example using requests-cache as a session provides persistent multi-process caching

@urschrei
Copy link
Owner

urschrei commented Dec 4, 2023

Thanks! I'm inclined to accept this PR, but I'd like to see some more documentation added explaining what the feature is for (just a simple example), and making it obvious that it's optional and most people don't have to worry about it.

@zacps zacps force-pushed the allow-passing-requests-session branch from f681dbd to 1385dd5 Compare December 4, 2023 00:51
@zacps
Copy link
Author

zacps commented Dec 4, 2023

Cool :). Do you think something like that would be enough?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants