Drop Python 3.4

[pquentin]

It reached its end-of-life on 2019-03-18.

As far as I can tell, remaining references are either still valid (eg. ssl.create_default_context exists since Python 3.4) or in contrib packages like rfc3986 or scripts like _appveyor/install.ps1.

[codecov-io]

Codecov Report

Merging #1604 into master will decrease coverage by 1.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1604      +/-   ##
==========================================
- Coverage   99.49%   98.47%   -1.02%     
==========================================
  Files          22       22              
  Lines        1972     1972              
==========================================
- Hits         1962     1942      -20     
- Misses         10       30      +20

Impacted Files	Coverage Δ
src/urllib3/util/wait.py	76.56% <0%> (-23.44%)	⬇️
src/urllib3/connection.py	92.36% <0%> (-1.39%)	⬇️
src/urllib3/util/url.py	98.34% <0%> (-1.11%)	⬇️
src/urllib3/response.py	99.72% <0%> (-0.28%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0d9ebc...0986091. Read the comment docs.

[codecov-io]

Codecov Report

Merging #1604 into master will decrease coverage by 0.36%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1604      +/-   ##
==========================================
- Coverage   99.73%   99.36%   -0.37%     
==========================================
  Files          22       22              
  Lines        1892     1892              
==========================================
- Hits         1887     1880       -7     
- Misses          5       12       +7

Impacted Files	Coverage Δ
src/urllib3/util/wait.py	89.06% <0%> (-10.94%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d813bc...7673f68. Read the comment docs.

[theacodes]

This is really up to pip. Has pip dropped 3.4 support? We won't until they do.

…

On Sat, May 11, 2019, 12:19 AM Codecov ***@***.***> wrote: Codecov <https://codecov.io/gh/urllib3/urllib3/pull/1604?src=pr&el=h1> Report Merging #1604 <https://codecov.io/gh/urllib3/urllib3/pull/1604?src=pr&el=desc> into master <https://codecov.io/gh/urllib3/urllib3/commit/7d813bce9b1e39e45678209ccca771e825bc9472?src=pr&el=desc> will *decrease* coverage by 0.36%. The diff coverage is n/a. [image: Impacted file tree graph] <https://codecov.io/gh/urllib3/urllib3/pull/1604?src=pr&el=tree> @@ Coverage Diff @@ ## master #1604 +/- ## ========================================== - Coverage 99.73% 99.36% -0.37% ========================================== Files 22 22 Lines 1892 1892 ========================================== - Hits 1887 1880 -7 - Misses 5 12 +7 Impacted Files <https://codecov.io/gh/urllib3/urllib3/pull/1604?src=pr&el=tree> Coverage Δ src/urllib3/util/wait.py <https://codecov.io/gh/urllib3/urllib3/pull/1604/diff?src=pr&el=tree#diff-c3JjL3VybGxpYjMvdXRpbC93YWl0LnB5> 89.06% <0%> (-10.94%) ⬇️ ------------------------------ Continue to review full report at Codecov <https://codecov.io/gh/urllib3/urllib3/pull/1604?src=pr&el=continue>. *Legend* - Click here to learn more <https://docs.codecov.io/docs/codecov-delta> Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov <https://codecov.io/gh/urllib3/urllib3/pull/1604?src=pr&el=footer>. Last update 7d813bc...7673f68 <https://codecov.io/gh/urllib3/urllib3/pull/1604?src=pr&el=lastupdated>. Read the comment docs <https://docs.codecov.io/docs/pull-request-comments> . — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1604 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAB5I47MTK7C5G3JONL4WWLPUZXPLANCNFSM4HMHPX4Q> .

[pquentin]

Ah, right. pip deprecated 3.4 but did not remove it yet. They forgot to remove it in 19.1. See pypa/pip#6106

I also need to figure out why the coverage is decreasing.

[pquentin]

There is a section in wait.py that is covered by Python 3.4 and Python 2.7. After this pull request it is only covered by Python 2.7, but codecov does not receive the 2.7 coverage info. This is why the coverage drops.

Maybe #1596 only fixed the coverage the issue for Python 3?

[sethmlarson]

I think there's an issue in our .coveragerc file. nox / tox

[pquentin]

All the Python 2.7 coverage uploads are failing in Travis, I think we need to fix that first

[pquentin]

Closing as this PR now conflicts and pip won't remove Python 3.4 support until pip 19.2, in order to wait for six months between the deprecation and the removal: pypa/pip#6106 (comment). (I said above that pip should have removed Python 3.4 in 19.1, but I had missed that comment, sorry.)

[pquentin]

pip finally dropped 3.4 support in 19.2 thanks to @hugovk in pypa/pip#6685, so we can do this in urllib3 now.

[sethmlarson]

Woo!!!

[pquentin]

Rebased, but 3.7 fails on Appveyor. Closing/reopening.

[pquentin]

The Python 3.7 Windows failure is reproducible. I compared the last good 3.7 build with the first bad 3.7 build, and noticed that Python was updated from 3.7.3 to 3.7.4, and OpenSSL from 1.1.0j to 1.1.1c as part of https://bugs.python.org/issue34631.

Here's my understanding of the failures:

• TestConnectionPool.test_source_address_error appears to fail because InvalidUrl is now being raised in the standard library and I guess we no longer catch the correct exception? But why only on Windows?
• TestHTTPS.test_client_no_intermediate and TestHTTPS_TLSv1_3.test_client_no_intermediate seem to fail because the OpenSSL exception is being converted into a SocketError in https://github.com/urllib3/urllib3/blob/master/src/urllib3/contrib/pyopenssl.py#L345-L346, maybe because the execution path changed?
• TestHTTPS_TLSv1_3.test_set_ssl_version_to_tls_version fails because there are no certs defined in TestHTTPS_TLSv1_3, so self.certs["ssl_version"] can't work

I'm not planning to continue working on this, sorry!

[sethmlarson]

Thanks for your investigation @pquentin. No problem. :)