feat: add support for span id and custom key for trace id and span id for otelzap #126
Conversation
pragmaticivan
force-pushed
the
span-id-and-custom-key-support
branch
from
d507252
to
be42e44
Compare
| @@ -439,7 +450,7 @@ func (s *SugaredLogger) FatalfContext(ctx context.Context, template string, args | |||
| func (s *SugaredLogger) logArgs( | |||
| ctx context.Context, lvl zapcore.Level, template string, args []interface{}, | |||
| ) { | |||
| if lvl < s.l.minLevel { | |||
| if lvl <= s.l.minLevel { | |||
There was a problem hiding this comment.
The current code for this line is causing some weird behaviors when the log level is debug
pragmaticivan
force-pushed
the
span-id-and-custom-key-support
branch
from
be42e44
to
f100fd1
Compare
|
Thanks for the PR, but otelzap now uses Otel Logs API which has top-level fields for trace & span ids. |
|
Hi @vmihailenco could you clarify that? this PR is backward compatible, it happens that many vendors don't follow the same API |
|
@pragmaticivan otelzap now does not inject trace_id/span_id and instead relies on Otel Logs API to do it automatically: https://github.com/uptrace/opentelemetry-go-extra/blob/main/otelzap/otelzap.go#L164-L196 And Otel Logs API will set trace/span ids on the |
New Relic would just need to support OpenTelemetry Logs API. |
fixes #109