Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added Screenshot in controls #936

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

Darsh0307
Copy link

GitHub Issue (If applicable): Close #911

PR Type

Docs changes

What kind of change does this PR introduce?

  • Documentation content changes

What is the current behavior?

No Screenshot explanation in Controls

What is the new behavior?

Screenshots in controls

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@Darsh0307
Copy link
Author

For Divider I will add the screenshot with the example which we have used in this PR. https://github.com/unoplatform/uno.toolkit.ui/pull/932/files

@Darsh0307
Copy link
Author

Copy link
Contributor

@kazo0 kazo0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about NavigationBar / TabBar?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're going to need some better images of the DrawerControl and DrawerFlyoutPresenter. Perhaps even a GIF to show it in use. The drawer samples in Gallery are pretty ugly, we should have something nicer looking for the docs

@Darsh0307
Copy link
Author

What about NavigationBar / TabBar?

@kazo0

Well there were enough screenshot when explaining the main use of navbar and tab bar.
So thats why i didnt envolved it.

But for DrawerControl and DrawerControl i can definetely make a GIF because thats look more cooler and nicer :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add screenshots to each control in the Toolkit (like there's in Material)
2 participants