Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added inputextensions returntype property #1128

Merged
merged 3 commits into from May 13, 2024
Merged

feat: added inputextensions returntype property #1128

merged 3 commits into from May 13, 2024

Conversation

rajamatt
Copy link
Contributor

@rajamatt rajamatt commented May 9, 2024 •
edited

GitHub Issue (If applicable): closes #1119

PR Type

What kind of change does this PR introduce?

  • Feature
  • Small sample
  • Documentation addition

What is the current behavior?

We have to specify android:ImeOptions="Next" and ios:ReturnKeyType="Next" if we want the return key on soft-keyboards to be Next.

What is the new behavior?

We only have to add utu:InputExtensions.ReturnType="Next" and Toolkit will handle the device specific cases itself.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@rajamatt rajamatt requested a review from kazo0 May 9, 2024 15:30
@rajamatt rajamatt self-assigned this May 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1128.eastus2.azurestaticapps.net

@agneszitte agneszitte requested a review from Xiaoy312 May 9, 2024 16:35
Xiaoy312
Xiaoy312 reviewed May 9, 2024
View reviewed changes
Copy link
Contributor

@Xiaoy312 Xiaoy312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also this pr should include relevant docs, and sample bits

@rajamatt rajamatt marked this pull request as ready for review May 9, 2024 18:54
@rajamatt
Copy link
Contributor Author

rajamatt commented May 9, 2024

Will add docs and sample for soft-keyboards.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1128.eastus2.azurestaticapps.net

2 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1128.eastus2.azurestaticapps.net

@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1128.eastus2.azurestaticapps.net

@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1128.eastus2.azurestaticapps.net

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1128.eastus2.azurestaticapps.net

agneszitte
agneszitte reviewed May 9, 2024
View reviewed changes
doc/helpers/Input-extensions.md Outdated Show resolved Hide resolved
doc/helpers/Input-extensions.md Outdated Show resolved Hide resolved
doc/helpers/Input-extensions.md Outdated Show resolved Hide resolved
...o.Toolkit.Samples/Uno.Toolkit.Samples.Shared/Content/Controls/InputExtensionsSamplePage.xaml Outdated Show resolved Hide resolved
src/Uno.Toolkit.UI/Behaviors/InputExtensions.cs Outdated Show resolved Hide resolved
doc/helpers/Input-extensions.md Outdated Show resolved Hide resolved
doc/helpers/Input-extensions.md Outdated Show resolved Hide resolved
doc/helpers/Input-extensions.md Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1128.eastus2.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1128.eastus2.azurestaticapps.net

kazo0
kazo0 reviewed May 10, 2024
View reviewed changes
src/Uno.Toolkit.UI/Behaviors/InputExtensions.cs Outdated Show resolved Hide resolved
src/Uno.Toolkit.UI/Behaviors/InputExtensions.cs Outdated Show resolved Hide resolved
src/Uno.Toolkit.UI/Behaviors/InputExtensions.cs Outdated Show resolved Hide resolved
src/Uno.Toolkit.UI/Behaviors/InputExtensions.cs Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1128.eastus2.azurestaticapps.net

1 similar comment
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1128.eastus2.azurestaticapps.net

@rajamatt rajamatt merged commit bb68c6a into main May 13, 2024
27 checks passed
@rajamatt rajamatt deleted the dev/mara/add-returntype branch May 13, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xiaoy312 Xiaoy312 Xiaoy312 approved these changes

@agneszitte agneszitte agneszitte left review comments

@kazo0 kazo0 kazo0 approved these changes

Assignees

@rajamatt rajamatt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[InputExtensions] Add ReturnType attached property
4 participants
@rajamatt @Xiaoy312 @kazo0 @agneszitte