HtmlControls: Added HtmlHxText elements, Added HtmlSelect/HtmlOption elements #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carldebilly
force-pushed
the
dev/cdb/html-more-controls
branch
from
2a74183
to
ed66194
Compare
carldebilly
changed the title
carldebilly
force-pushed
the
dev/cdb/html-more-controls
branch
from
7a90b25
to
fb52ba7
Compare
jeromelaban
approved these changes
Sep 7, 2021
nickrandolph
force-pushed
the
dev/cdb/html-more-controls
branch
from
fb52ba7
to
56340f6
Compare
|
@carldebilly I was trying to fix the CI issues on this but suspect I may have broken something as code is failing to compile with issues on methods ClearChildren, AddChild and RemoveChild. |
carldebilly
commented
Oct 29, 2022
Co-authored-by: Carl de Billy <carl.debilly@gmail.com>
Co-authored-by: Carl de Billy <carl.debilly@gmail.com>
Co-authored-by: Carl de Billy <carl.debilly@gmail.com>
Co-authored-by: Carl de Billy <carl.debilly@gmail.com>
nickrandolph
force-pushed
the
dev/cdb/html-more-controls
branch
from
295cf9d
to
a79d186
Compare
| { | ||
| if (args.NewValue is string str) | ||
| { | ||
| // TODO: Clearchildren no longer accessible |
There was a problem hiding this comment.
@carldebilly can you suggest what we should do here as ClearChildren isn't accessible as it's internal
|
@carldebilly is this sample still of value? Can you assist with the comments I've added so that we can get this PR merged. |
|
@carldebilly any chance we can close or complete this PR? |
|
@carldebilly Should I try to rebase this with the .NET7 changes to close this pr? And do we have something to replace "option.ClearChildren();"? Or should I just leave the todo's there? Also, is there anything else that should be done? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.