Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add Windowing to list of samples #680

Merged
merged 6 commits into from May 15, 2024
Merged

Conversation

MartinZikmund
Copy link
Member

No description provided.

doc/samples.md Outdated Show resolved Hide resolved
doc/samples.md Outdated Show resolved Hide resolved
@MartinZikmund MartinZikmund self-assigned this May 13, 2024
@MartinZikmund
Copy link
Member Author

@agneszitte on it!

Co-authored-by: Agnès ZITTE <16295702+agneszitte@users.noreply.github.com>
@agneszitte agneszitte disabled auto-merge May 14, 2024 18:49
@agneszitte agneszitte disabled auto-merge May 15, 2024 22:13
@agneszitte
Copy link
Contributor

@MartinZikmund Thank you a lot for the ReadMe and adjustments!
FYI I just pushed additional commits:

  • To move the solution files into a src folder
  • To keep alphabetical order for the samples list doc
  • To update to the latest stable versions to have the latest fixes

For example to have the fix for the pixelated images for Desktop:
Before
image
After
image

@agneszitte agneszitte enabled auto-merge May 15, 2024 22:23
@agneszitte agneszitte merged commit 9aa2416 into master May 15, 2024
7 checks passed
@agneszitte agneszitte deleted the dev/mazi/windowing-docs branch May 15, 2024 22:25
@agneszitte
Copy link
Contributor

@MartinZikmund FYI I noticed something when doing some last tests to make sure everything was fine with the latest stable versions. The Window.Title value is not properly Bind for Desktop:
image
If you can take a quick look tomorrow and open an issue for it if needed in Uno please

@MartinZikmund
Copy link
Member Author

@agneszitte that is most likely fixed by x:Bind adjustments that Youssef did and lifecycle changes on Skia, I will test later and bump Uno version if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants