New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: SingleProject - Commerce #644
base: master
Are you sure you want to change the base?
Conversation
Sample updated with latest template. Known issues so far:
I know there are more issues related to loading data. I will post them later after I test it more. |
b805a1b
to
80d7f10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vatsashah45, @eriklimakc
Few comments:
- Not sure if we can have a way to avoid having a Commerce folder inside an another Commerce folder here
- Remove unnecessary files
- And finally, if you can add a proper ReadMe for the sample please
To have a structure similar to what we have for ToDo here, with a src
folder with the source inside, a proper README.md with the details of the sample, and a doc
folder for additional documentation or assets needed for the README for example.
(cc @LProulx86 as well so we can use the same structure for the others samples)
We're currently facing this issue on this app - unoplatform/uno#16430 |
@eriklimakc, @vatsashah45 now that unoplatform/uno#16430 is closed, are there any issues left to finish the migration, please? |
Yes, I don't see the build error anymore, so that's fixed. But I see a regression, the Uno.Extensions.Storage.FileStorage issue (https://github.com/unoplatform/uno-private/issues/408) is back only on wasm, and that prevents products from loading: |
No description provided.