Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: WASM deadlock on AdvancedXBind sample #549

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: WASM deadlock on AdvancedXBind sample #549

wants to merge 2 commits into from

Conversation

Marc-Antoine-Soucy
Copy link
Contributor

Closes #417

@Marc-Antoine-Soucy
Copy link
Contributor Author

Not sure If I should fix both by adding #if !WASM in the viewmodel for both.

@nickrandolph
Copy link
Collaborator

Not sure If I should fix both by adding #if !WASM in the viewmodel for both.

Yeh this doesn't feel like a great experience given we're supposed to be "works on all platforms". I suspect we might want to rework the asynchelpers but let me round trip on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UI/AdvancedXBind] Wasm doesnt deploy properly
2 participants
@Marc-Antoine-Soucy @nickrandolph