Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no way to back on platform other than Skia #471

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Marc-Antoine-Soucy
Copy link
Contributor

closes #470

image

<skia:AppBarButton Content="Back" Click="NavigateBack" />
</CommandBar.PrimaryCommands>
</CommandBar>
<utu:NavigationBar Content="BlankPage2">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the whole point of this sample to show the native frame presenter and the out of the box CommandBar (https://platform.uno/docs/articles/controls/CommandBar.html)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I will update the description of the sample and try to make it work with the command bar. (I used the navigation bar because there were some inconsistencies )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unoplatform/uno#13284 made this issue, will wait for a response.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reading the description again, I see that I misunderstood a bit. But, I dont think the look of the IOS Commandbar iss acceptable
image
and on android, you also don't have the native back button even if you put nothing in the primary command on android
image
that's another bug I guess?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Android doesn't need a back button since there's a hardware button (or soft key now that most of those buttons are virtual). I think this is the correct behaviour for now

@nickrandolph nickrandolph marked this pull request as draft August 16, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI/NativeFrameNav] Lack of back button on some platforms
2 participants