New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: no way to back on platform other than Skia #471
base: master
Are you sure you want to change the base?
Conversation
<skia:AppBarButton Content="Back" Click="NavigateBack" /> | ||
</CommandBar.PrimaryCommands> | ||
</CommandBar> | ||
<utu:NavigationBar Content="BlankPage2"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't the whole point of this sample to show the native frame presenter and the out of the box CommandBar (https://platform.uno/docs/articles/controls/CommandBar.html)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I will update the description of the sample and try to make it work with the command bar. (I used the navigation bar because there were some inconsistencies )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unoplatform/uno#13284 made this issue, will wait for a response.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Android doesn't need a back button since there's a hardware button (or soft key now that most of those buttons are virtual). I think this is the correct behaviour for now
1f22582
to
eb77ea8
Compare
closes #470