Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade to node 16 #8215

Merged
merged 5 commits into from
Feb 16, 2022
Merged

chore: Upgrade to node 16 #8215

merged 5 commits into from
Feb 16, 2022

Conversation

searchableguy
Copy link
Collaborator

Description

Upgrade node version in our dockerfile to node 16. This should apply to all services using the file.

Let's see if it breaks anything.

Issues

Fixes #
Refs #

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

@searchableguy
Copy link
Collaborator Author

Due to how we detect changes in CI, this won't run all the tests though :/

Is there a way to forcefully run?

@clemsos
Copy link
Member

clemsos commented Feb 9, 2022

Yes you need to label the PR with run-all-tests then commit sth

@julien51
Copy link
Member

julien51 commented Feb 9, 2022

Also, want to try 14 first?

@searchableguy
Copy link
Collaborator Author

searchableguy commented Feb 10, 2022

Breaking changes introduced by npm
npm/cli#1935

We will need to change our scripts a little.

@julien51
Copy link
Member

Assigning to @clemsos for the smart contract tests issues...

@julien51 julien51 removed the request for review from clemsos February 16, 2022 13:44
@julien51
Copy link
Member

Team work is dream work!

@julien51
Copy link
Member

Annoyingly a bunch of styling things were added. It looks like my vscode prettyfying config has changed? Any hint @searchableguy on how to fix this?

@julien51
Copy link
Member

Also that fixes #7510

@julien51
Copy link
Member

Ok it looks like we have a green build!

@julien51 julien51 merged commit db6e090 into master Feb 16, 2022
@julien51 julien51 deleted the upgrade-node branch February 16, 2022 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants