Enhance rotate and zoom UI #112

CrafterSvK · 2023-08-06T15:47:31Z

Hello, I've been trying to get a hold of the codebase, so I've chosen the simplest thing I could think of.

Zooming in and out using buttons and mouse
Rotation
Zoom buttons should be disabled on min/max zoom

Rotation is currently handled by multiple keyboard input handlers which do separately things (rotate camera, rotate isometric objects). Need to merge to one keyboard handler which sends signals to other handlers.
In my opinion it would be lazy to solve this by making a global emitter, for these kinds of things, maybe that's right, I do not know. Or just make button to click rotate_left, rotate_right key :)

CrafterSvK · 2023-08-07T00:24:49Z

Every WorldThing can now react to rotation of camera. Maybe the emit to Global camera rotation from buttons can be directly made in TabWidget so there will be no need to signal it through PlayerHUD to CameraControls.

CrafterSvK · 2023-08-13T18:33:10Z

Buttons are now disabled on max/min zoom. It's handled using Global singleton, maybe refactoring to different Singleton would be better. Or if you find another way to do this, I would be glad.

CrafterSvK · 2023-08-20T09:33:51Z

@artism90 check it out if you've got time

artism90

There are a few issues remaining, otherwise it looks fine.

Assets/UI/TabWidgets/Buttons/MainButton/MainButtons/ZoomButton.gd

Assets/World/WorldThing.gd

Assets/World/Global.gd

Assets/World/Buildings/Lumberjack/Lumberjack.gd

CrafterSvK · 2023-09-04T16:58:42Z

I addressed the issues, thanks

artism90

The signal connection syntax was simplified in the previous PR, so it should be here too. Please also rebase to the master branch, and when everything done, squash all commits into one containing the PR message only.

Assets/UI/TabWidgets/Buttons/MainButton/MainButtons/ZoomButton.gd

Assets/World/WorldThing.gd

Assets/UI/TabWidgets/Buttons/MainButton/MainButtons/ZoomButton.gd

Assets/World/Global.gd

Assets/UI/TabWidgets/Buttons/MainButton/MainButtons/ZoomButton.gd

LinuxDonald · 2023-12-11T17:44:16Z

@CrafterSvK have you maybe time to get this pr done please?

theludovyc · 2024-01-25T15:54:26Z

Assets/Player/CameraControls.gd

+	Global.camera_zoom_out.connect(Callable(self, "_on_camera_zoom_out"))
+	Global.camera_rotate_left.connect(func(): rotate(-PI/2))
+	Global.camera_rotate_right.connect(func(): rotate(PI/2))
+
 func _process(delta: float) -> void:
 	_move(delta)
 	_move_drag()

 func _input(event: InputEvent) -> void:


Hello :) !

Please read this doc first https://docs.godotengine.org/en/stable/tutorials/inputs/inputevent.html

A thing that need to be said is checking inputs with _input, in _process or in _physics_process is really different.

You can test the code bellow by example

extends Node var i = 0 var j = 0 func _input(_event): i += 1 func _process(_delta): j += 1 func _notification(what): if what == NOTIFICATION_WM_CLOSE_REQUEST: prints(i, j)

_input is only called when an event occur. That mean it also not respect frame rate.

_process try to respect frame rate.

_process_physic follow frame rate.

So, we need to be pretty meticulous when we change the behavior of something in _input

theludovyc · 2024-01-25T15:55:28Z

Assets/Player/CameraControls.gd

+	if event.is_action_pressed("zoom_in"):
+		_zoom_mouse(-ZOOM_VALUE)

 	elif event.is_action_pressed("zoom_out"):
-		if _camera.size < ZOOM_OUT_LIMIT:
-			_zoom(ZOOM_VALUE)
+		_zoom_mouse(ZOOM_VALUE)


It is preferable to do that in _process func.

theludovyc · 2024-01-25T15:56:45Z

Assets/Player/CameraControls.gd

@@ -74,18 +71,45 @@ func _move_drag() -> void:
 			_origin.translate(move_dir)
 			_drag_pos = new_drag_pos

-func _rotate(rotation: float) -> void:
+func rotate(rotation: float) -> void:


It is not recommanded to call the func rotate. Chance is a "Node" type, but "Node2D" have a rotate func.

theludovyc · 2024-01-25T16:02:55Z

Assets/Player/CameraControls.gd

+func _zoom_mouse(zoom_value: float) -> void:
+	if _is_zoom_within_limit(zoom_value):
+		var m_pos := _viewport.get_mouse_position()
+		var start_result := _raycast_from_mouse(m_pos, 1)
+		_zoom_camera(zoom_value)
+		var end_result := _raycast_from_mouse(m_pos, 1)
+		if not (start_result.is_empty() and end_result.is_empty()):
+			var move_dir: Vector3i = start_result.position - end_result.position
+			_origin.translate(move_dir)
+
+		_zoom_limit_check()


Please read https://docs.godotengine.org/en/stable/tutorials/physics/ray-casting.html#d-ray-casting-from-screen

Also you can use math(Pythagore) instead physics engine. You know your plane is always on Y = 0.
Not same, but can help you https://github.com/theludovyc/Godot_DestropolisLike/blob/1081bde949fd27e9d43eb0d3e4cfa5e36faa1b8a/Script/Camera3D.gd#L15

theludovyc · 2024-01-25T16:06:28Z

Assets/Player/PlayerHUD.gd

+func _on_TabWidget_button_rotate_left_pressed() -> void:
+	emit_signal("button_rotate_left_pressed")
+
+func _on_TabWidget_button_rotate_right_pressed() -> void:
+	emit_signal("button_rotate_right_pressed")
+


If _on_TabWidget_button_rotate_left_pressed() is already called by signal, is not great to re-send a signal from it.

Signals with Godot is great powers, so come great responsability.

Try to use less as possible, they have cost on performances.

theludovyc · 2024-01-25T16:08:32Z

Assets/UI/TabWidgets/Buttons/MainButton/MainButtons/ZoomButton.gd

+func _ready() -> void:
+	pressed.connect(_on_ZoomButton_pressed)
+
+	if zoom_direction == ZOOM_DIRECTION.IN:


You can use match here, please read https://docs.godotengine.org/fr/4.x/tutorials/scripting/gdscript/gdscript_basics.html#match

You can also use composition to avoid this case

theludovyc · 2024-01-25T16:10:19Z

Assets/UI/TabWidgets/TabWidget.gd

@@ -14,6 +17,9 @@ signal button_game_menu_pressed

 func _ready() -> void:
 	if owner is PlayerHUD:
+		connect("button_rotate_left_pressed", Callable(owner, "_on_TabWidget_button_rotate_left_pressed"))


And if owner is not PlayerHUD what happens ? In which cases it happen ?

CrafterSvK force-pushed the camera branch from 4be38bb to e2e579b Compare August 6, 2023 20:52

CrafterSvK changed the title ~~[WIP] UI: Rotate and zoom~~ UI: Rotate and zoom Aug 7, 2023

CrafterSvK mentioned this pull request Aug 7, 2023

Port the ingame HUD #49

Open

LinuxDonald requested a review from artism90 August 26, 2023 21:16

artism90 requested changes Aug 27, 2023

View reviewed changes

artism90 added enhancement New feature or request ui Relating to Menus or the User Interface map Relating to the map or world or terrain code Programming code and game logic labels Sep 2, 2023

CrafterSvK requested a review from artism90 September 4, 2023 16:58

artism90 changed the title ~~UI: Rotate and zoom~~ Enhance rotate and zoom UI Sep 16, 2023

artism90 requested changes Sep 16, 2023

View reviewed changes

Assets/UI/TabWidgets/Buttons/MainButton/MainButtons/ZoomButton.gd Outdated Show resolved Hide resolved

Assets/World/WorldThing.gd Outdated Show resolved Hide resolved

Assets/UI/TabWidgets/Buttons/MainButton/MainButtons/ZoomButton.gd Outdated Show resolved Hide resolved

artism90 reviewed Sep 16, 2023

View reviewed changes

Assets/World/Global.gd Outdated Show resolved Hide resolved

artism90 reviewed Sep 16, 2023

View reviewed changes

Assets/UI/TabWidgets/Buttons/MainButton/MainButtons/ZoomButton.gd Outdated Show resolved Hide resolved

CrafterSvK added 8 commits January 24, 2024 18:24

added handling for rotate and zoom buttons

083c967

zoom is now handled globally

a86759a

wrong operator on rotate right

beb3926

remove duplicate camera rotate bindings

414465f

add missing CameraControls reference

c35f475

Zoom is now handled globally

d8b188b

code style

0dbe3c1

simplify code

dcf4b61

CrafterSvK force-pushed the camera branch from e081258 to dcf4b61 Compare January 24, 2024 17:29

theludovyc requested changes Jan 25, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enhance rotate and zoom UI #112

Enhance rotate and zoom UI #112

CrafterSvK commented Aug 6, 2023 •

edited

CrafterSvK commented Aug 7, 2023

CrafterSvK commented Aug 13, 2023

CrafterSvK commented Aug 20, 2023

artism90 left a comment

CrafterSvK commented Sep 4, 2023

artism90 left a comment

LinuxDonald commented Dec 11, 2023

theludovyc Jan 25, 2024 •

edited

theludovyc Jan 25, 2024

theludovyc Jan 25, 2024

theludovyc Jan 25, 2024 •

edited

theludovyc Jan 25, 2024

theludovyc Jan 25, 2024 •

edited

theludovyc Jan 25, 2024

Enhance rotate and zoom UI #112

Are you sure you want to change the base?

Enhance rotate and zoom UI #112

Conversation

CrafterSvK commented Aug 6, 2023 • edited

CrafterSvK commented Aug 7, 2023

CrafterSvK commented Aug 13, 2023

CrafterSvK commented Aug 20, 2023

artism90 left a comment

Choose a reason for hiding this comment

CrafterSvK commented Sep 4, 2023

artism90 left a comment

Choose a reason for hiding this comment

LinuxDonald commented Dec 11, 2023

theludovyc Jan 25, 2024 • edited

Choose a reason for hiding this comment

theludovyc Jan 25, 2024

Choose a reason for hiding this comment

theludovyc Jan 25, 2024

Choose a reason for hiding this comment

theludovyc Jan 25, 2024 • edited

Choose a reason for hiding this comment

theludovyc Jan 25, 2024

Choose a reason for hiding this comment

theludovyc Jan 25, 2024 • edited

Choose a reason for hiding this comment

theludovyc Jan 25, 2024

Choose a reason for hiding this comment

CrafterSvK commented Aug 6, 2023 •

edited

theludovyc Jan 25, 2024 •

edited

theludovyc Jan 25, 2024 •

edited

theludovyc Jan 25, 2024 •

edited