Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: fixup enable-ssh-askpass-require #289

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Conversation

dglynn
Copy link
Contributor

@dglynn dglynn commented Apr 2, 2024

License Acceptance

  • This repository is Apache version 2.0 licensed (some scripts may have alternate licensing inline in their code) and by making this PR, I am contributing my changes to the repository under the terms of the Apache 2 license.

Description

Fix typo in ssh-askpass-require->enable-ssh-askpass-require. The fragment file name and the function check for that file name didn't match so it would never ask for the passphrase on the cli in Linux.

This is now working as expected.

Fixes #229, #233

Type of changes

  • A helper script
  • A link to an external resource like a blog post or video
  • Text cleanups/updates
  • Test updates
  • Bug fix
  • New feature
  • Plugin list change

Checklist

  • I have read the CONTRIBUTING document.
  • I have updated the readme if this PR changes/updates quickstart functionality.
  • All new and existing tests pass.
  • Any scripts added use #!/usr/bin/env interpreter instead of potentially platform-specific direct paths (#!/bin/sh is an allowed exception)
  • Scripts are marked executable
  • Scripts do not have a language file extension unless they are meant to be sourced and not run standalone. No one should have to know if a script was written in bash, python, ruby or whatever. Not including file extensions makes it easier to rewrite the script in another language later without having to change every reference to the previous version.
  • I have added a credit line to README.md for the script
  • If there was no author credit in a script added in this PR, I have added one.
  • I have confirmed that the link(s) in my PR are valid.

Fix typo in ssh-askpass-require->enable-ssh-askpass-require.
The fragment file name and the function check for that file name didn't
match so it would never ask for the passphrase on the cli in Linux.

This is now working as expected.

Fixes unixorn#229, unixorn#233
Copy link

codeclimate bot commented Apr 2, 2024

Code Climate has analyzed commit 2c6747d and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Owner

@unixorn unixorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@unixorn unixorn merged commit ec5b5c6 into unixorn:main Apr 3, 2024
3 of 4 checks passed
@unixorn
Copy link
Owner

unixorn commented Apr 3, 2024

Thanks for the assist!

@dglynn
Copy link
Contributor Author

dglynn commented Apr 3, 2024

Ah you merged it before I did the proper signoff. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants