Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to disable using the 1Password ssh agent #288

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Conversation

unixorn
Copy link
Owner

@unixorn unixorn commented Apr 2, 2024

License Acceptance

  • This repository is Apache version 2.0 licensed (some scripts may have alternate licensing inline in their code) and by making this PR, I am contributing my changes to the repository under the terms of the Apache 2 license.

Description

Currently if op is found in the user's $PATH, the quickstart will try to use its ssh agent whether or not there are any keys in there. Make it possible for users to disable using the 1Password ssh agent.

Type of changes

  • A helper script
  • A link to an external resource like a blog post or video
  • Text cleanups/updates
  • Test updates
  • Bug fix
  • New feature
  • Plugin list change

Checklist

  • I have read the CONTRIBUTING document.
  • I have updated the readme if this PR changes/updates quickstart functionality.
  • All new and existing tests pass.
  • Any scripts added use #!/usr/bin/env interpreter instead of potentially platform-specific direct paths (#!/bin/sh is an allowed exception)
  • Scripts are marked executable
  • Scripts do not have a language file extension unless they are meant to be sourced and not run standalone. No one should have to know if a script was written in bash, python, ruby or whatever. Not including file extensions makes it easier to rewrite the script in another language later without having to change every reference to the previous version.
  • I have added a credit line to README.md for the script
  • If there was no author credit in a script added in this PR, I have added one.
  • I have confirmed that the link(s) in my PR are valid.

Currently if `op` is found in the user's `$PATH`, the quickstart
will try to use its `ssh` agent whether or not there are any keys
in there. Make it possible for users to disable using the 1Password
`ssh` agent.

Signed-off-by: Joe Block <jpb@unixorn.net>
@unixorn unixorn self-assigned this Apr 2, 2024
Copy link

codeclimate bot commented Apr 2, 2024

Code Climate has analyzed commit 4e0efcb and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

github-actions bot commented Apr 2, 2024

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ COPYPASTE jscpd yes no 1.25s
⚠️ MARKDOWN markdownlint 1 5 4.32s
✅ MARKDOWN markdown-table-formatter 1 0 0.66s
⚠️ REPOSITORY checkov yes 2 13.58s
✅ REPOSITORY devskim yes no 1.38s
✅ REPOSITORY dustilock yes no 0.01s
✅ REPOSITORY gitleaks yes no 0.43s
✅ REPOSITORY git_diff yes no 0.0s
✅ REPOSITORY grype yes no 11.53s
⚠️ REPOSITORY kics yes 2 1.61s
✅ REPOSITORY syft yes no 0.37s
✅ REPOSITORY trivy yes no 3.79s
✅ REPOSITORY trivy-sbom yes no 2.57s
✅ REPOSITORY trufflehog yes no 8.87s
✅ SPELL lychee 1 0 1.01s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Add `debug_out` to make debugging easier, and `zqs {en,dis}able-debug-mode` to toggle it.

Signed-off-by: Joe Block <jpb@unixorn.net>
@unixorn unixorn merged commit 983438c into main Apr 11, 2024
6 checks passed
@unixorn unixorn deleted the 1p-support branch April 11, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant