Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for so-fancy/diff-so-fancy #287

Merged
merged 3 commits into from
Apr 1, 2024
Merged

Add support for so-fancy/diff-so-fancy #287

merged 3 commits into from
Apr 1, 2024

Conversation

unixorn
Copy link
Owner

@unixorn unixorn commented Apr 1, 2024

License Acceptance

  • This repository is Apache version 2.0 licensed (some scripts may have alternate licensing inline in their code) and by making this PR, I am contributing my changes to the repository under the terms of the Apache 2 license.

Description

Type of changes

  • A helper script
  • A link to an external resource like a blog post or video
  • Text cleanups/updates
  • Test updates
  • Bug fix
  • New feature
  • Plugin list change

Checklist

  • I have read the CONTRIBUTING document.
  • I have updated the readme if this PR changes/updates quickstart functionality.
  • All new and existing tests pass.
  • Any scripts added use #!/usr/bin/env interpreter instead of potentially platform-specific direct paths (#!/bin/sh is an allowed exception)
  • Scripts are marked executable
  • Scripts do not have a language file extension unless they are meant to be sourced and not run standalone. No one should have to know if a script was written in bash, python, ruby or whatever. Not including file extensions makes it easier to rewrite the script in another language later without having to change every reference to the previous version.
  • I have added a credit line to README.md for the script
  • If there was no author credit in a script added in this PR, I have added one.
  • I have confirmed that the link(s) in my PR are valid.

Signed-off-by: Joe Block <jpb@unixorn.net>
- Add support for [diff-so-fancy](https://github.com/so-fancy/diff-so-fancy)
- Minor cleanups for readability

Signed-off-by: Joe Block <jpb@unixorn.net>
Copy link

codeclimate bot commented Apr 1, 2024

Code Climate has analyzed commit da3060f and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

github-actions bot commented Apr 1, 2024

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ COPYPASTE jscpd yes no 1.29s
⚠️ MARKDOWN markdownlint 1 5 1.15s
✅ MARKDOWN markdown-table-formatter 1 0 0.3s
⚠️ REPOSITORY checkov yes 2 12.75s
✅ REPOSITORY devskim yes no 1.41s
✅ REPOSITORY dustilock yes no 0.03s
✅ REPOSITORY gitleaks yes no 0.74s
✅ REPOSITORY git_diff yes no 0.0s
✅ REPOSITORY grype yes no 10.03s
⚠️ REPOSITORY kics yes 2 1.99s
✅ REPOSITORY syft yes no 0.15s
✅ REPOSITORY trivy yes no 4.57s
✅ REPOSITORY trivy-sbom yes no 3.1s
✅ REPOSITORY trufflehog yes no 7.7s
✅ SPELL lychee 1 0 2.17s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Signed-off-by: Joe Block <jpb@unixorn.net>
@unixorn unixorn merged commit 70a356e into main Apr 1, 2024
6 checks passed
@unixorn unixorn deleted the minor-cleanups branch April 1, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant