feat(python): refactor PythonAutoTestService and related classes for …

…improved performance and maintainability.
unit-mesh · May 8, 2024 · d889c77 · d889c77
1 parent 9f19dfb
commit d889c77
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 37 deletions.
diff --git a/pycharm/src/main/kotlin/cc/unitmesh/python/provider/PythonAutoTestService.kt b/pycharm/src/main/kotlin/cc/unitmesh/python/provider/PythonAutoTestService.kt
@@ -20,7 +20,6 @@ import com.intellij.psi.PsiFile
 import com.intellij.psi.PsiManager
 import com.intellij.psi.util.PsiTreeUtil
 import com.intellij.psi.util.PsiUtilBase
-import com.intellij.util.concurrency.annotations.RequiresWriteLock
 import com.jetbrains.python.PythonLanguage
 import com.jetbrains.python.psi.PyClass
 import com.jetbrains.python.psi.PyFile

diff --git a/pycharm/src/main/kotlin/cc/unitmesh/python/provider/PythonLivingDocumentation.kt b/pycharm/src/main/kotlin/cc/unitmesh/python/provider/PythonLivingDocumentation.kt
@@ -135,23 +135,23 @@ fun buildAndInsert(replacementText: String, anchor: PyDocStringOwner): PyDocStri
     val manager = PsiDocumentManager.getInstance(anchor.project)
     val document = manager.getDocument(anchor.containingFile)!!
     val beforeStatements = statements.prevSibling
-    var replacementWithLineBreaks = """
-                
-                $indentation$replacementText
-                """.trimIndent()
+    var replacementWithLineBreaks = (indentation + replacementText).trimIndent()
     if (statements.statements.isNotEmpty()) {
-        replacementWithLineBreaks += """
-                    
-                    $indentation
-                    """.trimIndent()
+        replacementWithLineBreaks += indentation.trimIndent()
     }
+
     val range = beforeStatements.textRange
-    if (beforeStatements !is PsiWhiteSpace) {
-        document.insertString(range.endOffset, replacementWithLineBreaks)
-    } else if (statements.statements.isEmpty() && beforeStatements.textContains('\n')) {
-        document.insertString(range.startOffset, replacementWithLineBreaks)
-    } else {
-        document.replaceString(range.startOffset, range.endOffset, replacementWithLineBreaks)
+
+    when {
+        beforeStatements !is PsiWhiteSpace -> {
+            document.insertString(range.endOffset, replacementWithLineBreaks)
+        }
+        statements.statements.isEmpty() && beforeStatements.textContains('\n') -> {
+            document.insertString(range.startOffset, replacementWithLineBreaks)
+        }
+        else -> {
+            document.replaceString(range.startOffset, range.endOffset, replacementWithLineBreaks)
+        }
     }
 
     return anchor

diff --git a/pycharm/src/main/kotlin/cc/unitmesh/python/provider/PythonPromptStrategyAdvisor.kt b/pycharm/src/main/kotlin/cc/unitmesh/python/provider/PythonPromptStrategyAdvisor.kt
diff --git a/pycharm/src/main/resources/cc.unitmesh.pycharm.xml b/pycharm/src/main/resources/cc.unitmesh.pycharm.xml
@@ -22,9 +22,6 @@
         <devFlowProvider
                 language="Python"
                 implementation="cc.unitmesh.python.provider.PythonAutoDevFlow"/>
-        <promptStrategy
-                language="Python"
-                implementation="cc.unitmesh.python.provider.PythonPromptStrategyAdvisor"/>
 
         <testContextProvider
                 language="Python"