Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ivy Failing Test: jax - activations.gelu #28161

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MuhammadNizamani
Copy link
Contributor

@MuhammadNizamani MuhammadNizamani commented Feb 2, 2024

PR Description

All test are passing locally
gelu

Related Issue

Closes #28160
Closes #28154

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

@Sarvesh-Kesharwani
Copy link
Contributor

Hi @MuhammadNizamani,
test is failing for one of the backends
here is the decorator you can use to reproduce the failure
@reproduce_failure('6.97.1', b'AXicY2QAAsYDDxhggBFK58BFADLuAhA=')
Thanks
image
image

@MuhammadNizamani
Copy link
Contributor Author

@Sarvesh-Kesharwani I will look into it Thanks for review

@samthakur587
Copy link
Contributor

Hii @MuhammadNizamani the changes you made also not good float16 dtype the tol value you kept more then 1e-2 it's not making any sense here.

@ivy-seed
Copy link

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

@MuhammadNizamani
Copy link
Contributor Author

i am working on it

Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any updates @MuhammadNizamani
Does decreasing tolerance help here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Ivy Failing Test: torch - activations.gelu Fix Ivy Failing Test: jax - activations.gelu
6 participants