Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[US-20] Update examples with new builtin helper functions #249

Conversation

kellemNegasi
Copy link
Contributor

@kellemNegasi kellemNegasi commented Apr 26, 2024

@kellemNegasi kellemNegasi marked this pull request as ready for review April 29, 2024 15:32
Copy link
Contributor

@sampila sampila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, added minor comment

@@ -31,7 +29,7 @@ func init() {
panic(err)
}

common.SetLogger(common.NewConsoleLogger(common.LogLevelDebug))
// common.SetLogger(common.NewConsoleLogger(common.LogLevelDebug))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove commented code

@3ace
Copy link
Contributor

3ace commented Apr 30, 2024

since the new helper function would be included in a new unipdf release, I think this PR should be put in draft mode first. Otherwise this updated example would not working correctly.

After there's a new unipdf release, you could reopen the PR and don't forget to update dependency to use the latest unipdf version.

@kellemNegasi kellemNegasi marked this pull request as draft May 1, 2024 08:53
@kellemNegasi kellemNegasi marked this pull request as ready for review May 2, 2024 16:19
@kellemNegasi kellemNegasi requested a review from sampila May 2, 2024 16:19
Copy link
Contributor

@sampila sampila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@3ace 3ace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@3ace 3ace merged commit af296ca into unidoc:master May 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants