New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[US-20] Update examples with new builtin helper functions #249
[US-20] Update examples with new builtin helper functions #249
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, added minor comment
@@ -31,7 +29,7 @@ func init() { | |||
panic(err) | |||
} | |||
|
|||
common.SetLogger(common.NewConsoleLogger(common.LogLevelDebug)) | |||
// common.SetLogger(common.NewConsoleLogger(common.LogLevelDebug)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove commented code
since the new helper function would be included in a new unipdf release, I think this PR should be put in draft mode first. Otherwise this updated example would not working correctly. After there's a new unipdf release, you could reopen the PR and don't forget to update dependency to use the latest unipdf version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
PR for https://unidoc.atlassian.net/browse/US-20