Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[US-392] File attachment examples #245

Merged
merged 6 commits into from
Apr 17, 2024
Merged

[US-392] File attachment examples #245

merged 6 commits into from
Apr 17, 2024

Conversation

3ace
Copy link
Contributor

@3ace 3ace commented Apr 17, 2024

Add code examples for new feature of attaching files which introduced in UniPDF 3.57.0

sampila
sampila approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@sampila sampila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, looks like there's an issue on synk

@3ace 3ace marked this pull request as draft April 17, 2024 07:16
@3ace 3ace marked this pull request as ready for review April 17, 2024 07:17
@3ace 3ace marked this pull request as draft April 17, 2024 09:13
@3ace 3ace marked this pull request as ready for review April 17, 2024 10:06
@3ace 3ace requested a review from sampila April 17, 2024 10:06
@3ace
Copy link
Contributor Author

3ace commented Apr 17, 2024

@sampila @anovik I've resolved the issue with our dependency for this PR

sampila
sampila approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@sampila sampila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@3ace 3ace merged commit 8a0f752 into master Apr 17, 2024
6 checks passed
@3ace 3ace deleted the us-392-file-attachment-examples branch April 17, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anovik anovik anovik approved these changes

@sampila sampila sampila approved these changes

@gunnsth gunnsth Awaiting requested review from gunnsth

@kellemNegasi kellemNegasi Awaiting requested review from kellemNegasi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@3ace @anovik @sampila