Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema for: CT_ImageData, CT_OleObject, CT_Shape and support inside (CT_Object). #334

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

zhexiao
Copy link

@zhexiao zhexiao commented Oct 9, 2019

This change is Reviewable

@CLAassistant
Copy link

CLAassistant commented Oct 9, 2019

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 9, 2019

Codecov Report

Merging #334 into master will increase coverage by 2.18%.
The diff coverage is 67.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #334      +/-   ##
==========================================
+ Coverage   52.16%   54.34%   +2.18%     
==========================================
  Files         198      200       +2     
  Lines       13924    16424    +2500     
==========================================
+ Hits         7263     8926    +1663     
- Misses       6260     6812     +552     
- Partials      401      686     +285
Impacted Files Coverage Δ
document/oleobject.go 0% <ø> (ø) ⬆️
document/run.go 9.09% <ø> (ø) ⬆️
spreadsheet/cell.go 45.82% <0%> (-3.68%) ⬇️
spreadsheet/workbook.go 56.69% <0%> (-0.56%) ⬇️
spreadsheet/formula/invalidreferencecontext.go 0% <0%> (ø) ⬆️
spreadsheet/context.go 0% <0%> (ø) ⬆️
spreadsheet/formula/fntext.go 70.85% <53.84%> (-0.08%) ⬇️
spreadsheet/formula/fnindex.go 62.76% <57.14%> (+3.07%) ⬆️
spreadsheet/read.go 62.16% <66.66%> (-0.34%) ⬇️
document/document.go 54.18% <7.14%> (-3.46%) ⬇️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05ce52b...01c74ee. Read the comment docs.

@gunnsth gunnsth added this to Document in Issue Overview Nov 18, 2019
document/document.go Outdated Show resolved Hide resolved
document/document.go Outdated Show resolved Hide resolved
document/document.go Outdated Show resolved Hide resolved
document/oleobject.go Outdated Show resolved Hide resolved
@gunnsth gunnsth added the pending Awaiting feedback label Nov 18, 2019
@gunnsth
Copy link
Contributor

gunnsth commented Nov 18, 2019

@zhexiao Thanks very much for your contribution.

In summary, it looks to me that the PR involves:

  • Schema for: CT_ImageData, CT_OleObject, CT_Shape and support inside (CT_Object).
  • OleObjects() for Run
  • DrawingInline() for Run
  • document functions for working with OleObjectPath
  • Wmf file oleobject reading

Do you have any examples/testcases that demonstrate how this new functionality can be used?

@zhexiao
Copy link
Author

zhexiao commented Dec 20, 2019

@zhexiao Thanks very much for your contribution.

In summary, it looks to me that the PR involves:

  • Schema for: CT_ImageData, CT_OleObject, CT_Shape and support inside (CT_Object).
  • OleObjects() for Run
  • DrawingInline() for Run
  • document functions for working with OleObjectPath
  • Wmf file oleobject reading

Do you have any examples/testcases that demonstrate how this new functionality can be used?

Yes, You are right. My code is aimd to parse the Word OleObject .
Let me update the commit/comment info and create some tests.

@zhexiao zhexiao changed the title Get inline image from Document Run Schema for: CT_ImageData, CT_OleObject, CT_Shape and support inside (CT_Object). Dec 20, 2019
@zhexiao
Copy link
Author

zhexiao commented Dec 20, 2019

@zhexiao Thanks very much for your contribution.

In summary, it looks to me that the PR involves:

  • Schema for: CT_ImageData, CT_OleObject, CT_Shape and support inside (CT_Object).
  • OleObjects() for Run
  • DrawingInline() for Run
  • document functions for working with OleObjectPath
  • Wmf file oleobject reading

Do you have any examples/testcases that demonstrate how this new functionality can be used?

I just added an oleObject exmaple, please take a look.
example path: _examples/document/oleobject
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending Awaiting feedback
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants