Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semicolons; revisited #819

Merged
merged 2 commits into from
May 16, 2024
Merged

Semicolons; revisited #819

merged 2 commits into from
May 16, 2024

Conversation

josh-hadley
Copy link
Collaborator

pre-16.0 beta public feedback pointed out some issues with the first pass at addressing UTC-179-A113. After some discussion with other PAG members, we decided to make the definition of "Semicolons" to be U+003B and its compatibility equivalents.

reduce set of semicolons in SContinue to include only U+003B and its compatibility equivalents. Spurred by https://www.unicode.org/review/pri494/feedback.html#ID20240509103608 and discussion amongst PAG members.
Copy link
Contributor

@Ken-Whistler Ken-Whistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks o.k.

@markusicu
Copy link
Member

Hi @josh-hadley are you ready to merge this? I would like to get a snapshot of the UCD proper for UCDXML and the beta.

@josh-hadley
Copy link
Collaborator Author

Hi @josh-hadley are you ready to merge this? I would like to get a snapshot of the UCD proper for UCDXML and the beta.

Almost ready. I wanted to give the author of the feedback that initiated this change an opportunity to look it over first. If I don't hear anything soon I'll go ahead and merge and get you un-blocked.

@dscorbett
Copy link

My original feedback was specifically about the non-common-script semicolons. This PR also removes two common-script semicolons: U+204F REVERSED SEMICOLON and U+2E35 TURNED SEMICOLON. I don’t know how those should be categorized, but I wanted to check with you that their removal was intentional. FWIW, L2/12-168 shows U+204F REVERSED SEMICOLON used as a standard semicolon in right-to-left Old Hungarian. That’s all the feedback I have on this PR.

@markusicu
Copy link
Member

Thanks, David.
We "inherited" a less-than-clear task and may have gone too far.
I like what Josh and Robin have done here: Dial it back to a principled, defensible subset of characters.
I think it would be useful to merge this PR as is and leave it at that for the start of the 16.0 beta.
Also retaining two more sc=Common characters could be ok too if @josh-hadley feels like making those changes.
During beta (and beyond) we can discuss the various "semicolons" further.

@josh-hadley
Copy link
Collaborator Author

it would be useful to merge this PR as is and leave it at that for the start of the 16.0 beta

Agreed, and I'll proceed with that.

Thanks for responding @dscorbett!

@josh-hadley josh-hadley merged commit a8e8f5e into main May 16, 2024
22 checks passed
@josh-hadley josh-hadley deleted the jh-semicolons-revisited branch May 16, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants