Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IDNA] Clean up GenerateIdnaTest.testCases #712

Merged
merged 1 commit into from
May 14, 2024

Conversation

cketti
Copy link
Contributor

@cketti cketti commented Feb 18, 2024

  • Removes unused data and converts testCases to a simple String array
  • Removes duplicate entries

This shouldn't introduce any (significant) behavior changes. The generated output is the same as it was before.

- Removes unused data and converts `testCases` to a simple String array
- Removes duplicate entries
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
So yes, most of the test cases used to include additional fields like in the test data output, but they were not used and thus may have been out of sync with reality.
And the last few test cases already only had the input strings.
It looks like all of the same test cases are still there, minus some duplicates.
The duplicates used to have cases for transitional vs. nontransitional processing, but again, those details were ignored.

@markusicu markusicu merged commit 63e9971 into unicode-org:main May 14, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants