Fix docs test that uses networking #4882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
reviewed
May 8, 2024
provider/blob/src/export/mod.rs
Outdated
Comment on lines
25
to
29
| //! .with_locales_and_fallback([LocaleFamily::FULL], { | ||
| //! let mut options = FallbackOptions::default(); | ||
| //! options.deduplication_strategy = Some(DeduplicationStrategy::None); | ||
| //! options | ||
| //! }) |
There was a problem hiding this comment.
Suggestion (optional): since BlobExporter does not support runtime fallback, DeduplicationStrategy::None is the default, so you don't need to set it explicitly here
Comment on lines
28
to
30
| //! let mut options = FallbackOptions::default(); | ||
| //! options.deduplication_strategy = Some(DeduplicationStrategy::None); | ||
| //! options |
There was a problem hiding this comment.
Suggestion: set runtime_fallback_location to External here, and then deduplication_strategy will be inferred to be None.
provider/fs/src/export/mod.rs
Outdated
Comment on lines
31
to
35
| //! .with_locales_and_fallback([LocaleFamily::FULL], { | ||
| //! let mut options = FallbackOptions::default(); | ||
| //! options.deduplication_strategy = Some(DeduplicationStrategy::None); | ||
| //! options | ||
| //! }) |
There was a problem hiding this comment.
Suggestion: it should work fine with Default::default().
|
@sffc please just make the changes |
sffc
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.