Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add helpers for converting LanguageIdentifier to LocaleFamily #4855

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add helpers for converting LanguageIdentifier to LocaleFamily #4855

wants to merge 1 commit into from

Conversation

sffc
Copy link
Member

@sffc sffc commented Apr 30, 2024

Part of #4629

@sffc sffc requested a review from robertbastian April 30, 2024 23:47
@sffc sffc requested a review from Manishearth as a code owner April 30, 2024 23:47
@Manishearth Manishearth removed their request for review May 1, 2024 00:02
@Manishearth
Copy link
Member

I don't strongly feel like we need these APIs but I'm not opposed to adding them, defer to @robertbastian

@sffc
Copy link
Member Author

sffc commented May 1, 2024

I don't strongly feel like we need these APIs but I'm not opposed to adding them, defer to @robertbastian

Exactly why I made this its own pull request, so we can decide one way or another

@robertbastian
Copy link
Member

I don't really see the need for these, and I'm also not a fan of the auto, and especially auto_iter names. Meh

robertbastian
robertbastian reviewed May 2, 2024
View reviewed changes
Copy link
Member

@robertbastian robertbastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@sffc sffc added the discuss Discuss at a future ICU4X-SC meeting label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertbastian robertbastian robertbastian left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
discuss Discuss at a future ICU4X-SC meeting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sffc @Manishearth @robertbastian