Implement Extended Currency DataModel #4706
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
younies
force-pushed
the
add-long-currency-data
branch
from
a7c1b5a
to
6cd6f90
Compare
sffc
reviewed
Mar 27, 2024
Comment on lines
41
to
45
| /// A mapping from each currency's ISO code to its associated formatting patterns. | ||
| // Using CurrencyPatternConfig until implementing AsULE for ExtendedCurrencyPatternConfig. | ||
| // use short for long right now. | ||
| #[cfg_attr(feature = "serde", serde(borrow))] | ||
| pub patterns_config: ZeroMap<'data, Count, CurrencyPatternConfig>, |
There was a problem hiding this comment.
Suggestion: I think in general the best way to store things that vary by plural form is to pull out the other variant and store all the others in the map. Something more like
/// For plural form 'other'
pub pattern_config_other: CurrencyPatternConfig,
/// For all other plural forms and explicit forms
pub pattern_config_plurals: ZeroMap<'data, Count, CurrencyPatternConfig>,This is good because
- The fallback to
otheris infallible - In locales that don't use plurals (like CJK), the ZeroMap becomes empty, which is nice
There was a problem hiding this comment.
great idea, we treated it as default pattern.
younies
changed the title
younies
changed the title
younies
commented
Apr 30, 2024
| // } | ||
| // } | ||
|
|
||
| impl IterableDataProviderInternal<CurrencyExtendedDataV1Marker> for crate::DatagenProvider { |
There was a problem hiding this comment.
needs to generate the data locale with auxiliary key.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.