Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce DataModule for Units Formatting #4660

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Introduce DataModule for Units Formatting #4660

wants to merge 13 commits into from

Conversation

younies
Copy link
Member

@younies younies commented Mar 7, 2024 •
edited

No description provided.

@younies younies marked this pull request as draft March 7, 2024 10:08
sffc
sffc reviewed Mar 7, 2024
View reviewed changes
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLDR data add looks good. I think we should sketch out the initial data struct before merging this.

@younies younies changed the title Implement DataModule for short and narrow units formatter Introduce DataModule for Short&Narrow Unit Formatting Mar 17, 2024
@younies younies changed the title Introduce DataModule for Short&Narrow Unit Formatting Introduce DataModule for Basic Units Formatting Mar 20, 2024
@younies younies changed the title Introduce DataModule for Basic Units Formatting Introduce DataModule for Units Formatting May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc left review comments

@robertbastian robertbastian Awaiting requested review from robertbastian robertbastian is a code owner

@Manishearth Manishearth Awaiting requested review from Manishearth Manishearth is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@younies @sffc