Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22723 Add line number info to icuexportdata handleError #3004

Merged

Conversation

mihnita
Copy link
Contributor

@mihnita mihnita commented May 10, 2024

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22723
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@mihnita mihnita requested a review from sffc May 10, 2024 21:23
@mihnita
Copy link
Contributor Author

mihnita commented May 10, 2024

Small "quality of life improvement"
We talked about it.


And I hope using ICU-22723 for small cleanup changes like these is OK.
See comments on PR #3001

mihnita: I hope that the issues is OK (ICU-22723: "ICU 76rc BRS")
markusicu: rc BRS ticket is fine

If not, I think it would be nice to have a general "catch-all" issue for small code improvements.
Similar to ICU-22722 "ICU 76 docs minor fixes".
Reviewers can always ask for a separate issue if they think that the change does not qualify as "minor fix"

@mihnita mihnita force-pushed the mihai_line_info_to_icuexportdata_error branch from 9a3fdea to d2699d5 Compare May 13, 2024 18:06
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@mihnita mihnita merged commit 75ef0d9 into unicode-org:main May 13, 2024
97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants