ICU-22610 Use Requires.private and Libs.private #2949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Please sign the CLA using the CLA button. We need that signed and confirmed via the CLA Assistant checker before we can take a look. |
To prevent overlinking when publishing shared libraries,
specify internal dependencies using Requires.private and
Libs.private.
Use Libs.private in icu-uc.pc for libicudata.so, and
Requires.private in icu-i18n.pc, icu-io.pc, and icu-lx.pc,
so that ICU internal dependencies will not be bound
into clients.
The resulting *.pc files will produce the following
output for icu-i18n and icu-lx, provided pkgconf has
commit 78d53ea0 (2.2.0 or later) which de-duplicates
multiple -L options:
commit 78d53ea012dfbaf397bf8e6907efac5b51abac56
Author: Kai Pastor <dg0yt@darc.de>
Date: Fri Feb 23 15:18:08 2024 +0100
Revise serials, traversal, flattening
./configure --enable-shared ...
#
# icu-i18n
#
% pkgconf --libs icu-i18n
-L/opt/local/lib -licui18n
% pkgconf --libs --static icu-i18n
-L/opt/local/lib -licui18n -licuuc -licudata -lpthread -lm
#
# icu-lx
#
% pkgconf --libs icu-lx
-L/opt/local/lib -liculx
% pkgconf --libs --static icu-lx
-L/opt/local/lib -liculx -L/usr/lib/x86_64-linux-gnu -licu-le-hb -lharfbuzz -lm -licuuc -licudata -lpthread -lm
./configure --disable-shared --enable-static ...
#
# icu-i18n
#
% pkgconf --libs icu-i18n
-L/opt/local/lib -licui18n -licuuc -licudata -lpthread -lm
% pkgconf --libs --static icu-i18n
-L/opt/local/lib -licui18n -licuuc -licudata -lpthread -lm
#
# icu-lx
#
% pkgconf --libs icu-lx
-L/opt/local/lib -liculx -L/usr/lib/x86_64-linux-gnu -licu-le-hb
% pkgconf --libs --static icu-lx
-L/opt/local/lib -liculx -L/usr/lib/x86_64-linux-gnu -licu-le-hb -lharfbuzz -licuuc -licudata -lpthread -lm
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
|
@markusicu Mix up with CLA signing sorted out. |
|
@echeran @markusicu AFAICT CLA Assistant checker confirms the CLA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent overlinking when publishing shared libraries, specify internal dependencies using Requires.private and Libs.private.
Use Libs.private in icu-uc.pc for libicudata.so, and Requires.private in icu-i18n.pc, icu-io.pc, and icu-lx.pc, so that ICU internal dependencies will not be bound into clients.
The resulting *.pc files will produce the following output for icu-i18n and icu-lx, provided pkgconf has commit 78d53ea0 (2.2.0 or later) which de-duplicates multiple -L options:
./configure --enable-shared ..../configure --disable-shared --enable-static ...Checklist