Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-22718 Export disallowed/ignored UTS 46 data for ICU4X #2945

Merged
merged 1 commit into from May 15, 2024
Merged

ICU-22718 Export disallowed/ignored UTS 46 data for ICU4X #2945

merged 1 commit into from May 15, 2024

Conversation

hsivonen
Copy link
Member

@hsivonen hsivonen commented Apr 3, 2024 •
edited

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22718
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@hsivonen hsivonen mentioned this pull request Apr 4, 2024
Merged
@hsivonen
Copy link
Member Author

hsivonen commented Apr 4, 2024

The ICU4X PR is unicode-org/icu4x#4712

@markusicu markusicu self-assigned this Apr 11, 2024
@markusicu markusicu requested a review from echeran April 11, 2024 16:18
@hsivonen hsivonen marked this pull request as ready for review April 24, 2024 14:58
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/tools/icuexportdata/icuexportdata.cpp is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/tools/icuexportdata/icuexportdata.cpp is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

markusicu
markusicu reviewed May 10, 2024
View reviewed changes
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build failure seems to pop up for any C++ change now :-(
I will send an email to the team.

icu4c/source/tools/icuexportdata/icuexportdata.cpp Show resolved Hide resolved
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/tools/icuexportdata/icuexportdata.cpp is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@markusicu
Copy link
Member

Please rebase and resolve the merge conflict.

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/tools/icuexportdata/icuexportdata.cpp is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/tools/icuexportdata/icuexportdata.cpp is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@hsivonen
Copy link
Member Author

Rebased. Adapted to the line-number-reporting error handling and fixed stylistic consistency of comparing for zero.

@hsivonen
Copy link
Member Author

Backport in #3009

@markusicu markusicu merged commit 3988908 into unicode-org:main May 15, 2024
97 checks passed
@hsivonen hsivonen deleted the icu4x-uts46bis-main branch May 20, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusicu markusicu markusicu approved these changes

@echeran echeran Awaiting requested review from echeran

Assignees

@markusicu markusicu

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@hsivonen @markusicu