Fix some links in documentation #2666
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Skip over the manual redirects that are icu4[cj]/readme.html. - Update links: site.icu-project.org/processes/contribute is no more. - Update link paths: some relative links in moved docs were pointing at userguide/icu4c/icu4c - Add .html suffixes, letting unicode-org.github.io sidebar correctly show which page is being viewed. However it would also break Markdown navigation. Which use case are we optimising for? GitHub Pages, or Markdown source? I wasn't very thorough with my searches, this was based on broken links rgrep processes/contribute . rgrep 'icu4[cj]/readme.html' . egrep -r '/packaging)|/build)' . I've not fixed all the /icudata.md links yet for example. Should perhaps add all of those to this PR?
hugovdm
commented
Oct 10, 2023
| @@ -530,6 +529,10 @@ Jira. | |||
| 2. Use the drop-down to change the fix version to the next ICU version | |||
| 3. Click "Save" next to the filter title | |||
|
|
|||
| ## Update this document | |||
There was a problem hiding this comment.
Intended as a "WIP / DO NOT SUBMIT"
hugovdm
commented
Oct 10, 2023
| @@ -69,8 +69,8 @@ MSVC compiler. See the [Building ICU4C](./icu4c/build) page. | |||
|
|
|||
| #### Can you help me build ICU4C for ... | |||
|
|
|||
| We can try ... make sure you read the [Building ICU4C](./icu4c/build) section and also the [ICU | |||
| Data](../icudata.md) section. You might also [searching the icu-support | |||
There was a problem hiding this comment.
Several more references to icudata.md - I propose I try to update all of them in this PR
|
FYI: You no longer need to ensure the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: maybe this should become part of ICU-22438 ?
I wasn't very thorough with my searches, this was based on broken links
rgrep processes/contribute .
rgrep 'icu4[cj]/readme.html' .
egrep -r '/packaging)|/build)' .
I've not fixed all the /icudata.md links yet for example. Should perhaps add all of those to this PR?
Checklist